Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

2019-12-18 Thread Sam Ravnborg
Hi Jani. > As I wrote in [1], this allows a configuration that builds and links, > but is silently broken. You won't get backlight support in drm panel > which would be a reasonable expectation with > CONFIG_BACKLIGHT_CLASS_DEVICE=m. Agreed - it needs to be improved. But right now we had to fix

Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

2019-12-18 Thread Jani Nikula
On Tue, 17 Dec 2019, Sam Ravnborg wrote: > On Tue, Dec 17, 2019 at 08:25:03AM -0800, Randy Dunlap wrote: >> On 12/17/19 6:07 AM, Andy Shevchenko wrote: >> > The initial commit followed by the fix didn't take into consideration the >> > case >> > >> > CONFIG_DRM_PANEL=y >> >

[PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

2019-12-18 Thread Andy Shevchenko
The initial commit followed by the fix didn't take into consideration the case CONFIG_DRM_PANEL=y CONFIG_BACKLIGHT_CLASS_DEVICE=m CONFIG_DRM_I915=y where symbol devm_of_find_backlight() is not reachable from DRM subsystem. Quick fix is to avoid drm_panel_of_backlight() from exporting in such

Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

2019-12-18 Thread Randy Dunlap
On 12/17/19 6:07 AM, Andy Shevchenko wrote: > The initial commit followed by the fix didn't take into consideration the case > > CONFIG_DRM_PANEL=y > CONFIG_BACKLIGHT_CLASS_DEVICE=m > CONFIG_DRM_I915=y > > where symbol devm_of_find_backlight() is not reachable from DRM subsystem. > Quick fix is

Re: [PATCH v1 1/1] drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time

2019-12-17 Thread Sam Ravnborg
On Tue, Dec 17, 2019 at 08:25:03AM -0800, Randy Dunlap wrote: > On 12/17/19 6:07 AM, Andy Shevchenko wrote: > > The initial commit followed by the fix didn't take into consideration the > > case > > > > CONFIG_DRM_PANEL=y > > CONFIG_BACKLIGHT_CLASS_DEVICE=m > > CONFIG_DRM_I915=y > > > > where