RE: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-18 Thread Flavio Suligoi
Hi Daniel, ... > Subject: Re: [PATCH v1 1/2] backlight: mp3309c: Make use of device > properties > > +++ b/drivers/video/backlight/mp3309c.c > > @@ -15,6 +15,8 @@ > > #include > > #include > > #include > > +#include > > +#include > >

Re: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-15 Thread Andy Shevchenko
On Fri, Dec 15, 2023 at 04:11:02PM +, Daniel Thompson wrote: > On Thu, Dec 14, 2023 at 09:51:13PM +0200, Andy Shevchenko wrote: ... > > static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, > > Pretty minor... but I wonder if it should be renamed: > mp3309c_parse_fwnode(). I am fine

Re: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-15 Thread Daniel Thompson
On Thu, Dec 14, 2023 at 09:51:13PM +0200, Andy Shevchenko wrote: > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Add mod_devicetable.h include. > > Signed-off-by: Andy Shevchenko > --- > drivers/video/backlight/mp3309c.c | 38

RE: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-15 Thread Flavio Suligoi
> Subject: [PATCH v1 1/2] backlight: mp3309c: Make use of device > properties > > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Add mod_devicetable.h include. > > Signed-off-by: Andy Shevchenko > --- >

[PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-14 Thread Andy Shevchenko
Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Add mod_devicetable.h include. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 38 --- 1 file changed, 15 insertions(+), 23 deletions(-) diff