Re: [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h

2019-07-19 Thread Sam Ravnborg
Hi Christian. Thanks for your comments and very valid question. On Fri, Jul 19, 2019 at 06:56:47AM +, Koenig, Christian wrote: > Am 18.07.19 um 18:15 schrieb Sam Ravnborg: > > drm_file used drm_magic_t from uapi/drm/drm.h. > > This is a simple unsigned int. > > Just opencode it as such to bre

Re: [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h

2019-07-18 Thread Koenig, Christian
Am 18.07.19 um 18:15 schrieb Sam Ravnborg: > drm_file used drm_magic_t from uapi/drm/drm.h. > This is a simple unsigned int. > Just opencode it as such to break the dependency from this header file > to uapi. Mhm, why do you want to remove UAPI dependency here in the first place? I mean the type

Re: [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h

2019-07-18 Thread Sean Paul
On Thu, Jul 18, 2019 at 06:15:07PM +0200, Sam Ravnborg wrote: > drm_file used drm_magic_t from uapi/drm/drm.h. > This is a simple unsigned int. > Just opencode it as such to break the dependency from this header file > to uapi. > > Signed-off-by: Sam Ravnborg Passes my build tests, thanks for th

[PATCH v1 11/11] drm: drop uapi dependency from drm_file.h

2019-07-18 Thread Sam Ravnborg
drm_file used drm_magic_t from uapi/drm/drm.h. This is a simple unsigned int. Just opencode it as such to break the dependency from this header file to uapi. Signed-off-by: Sam Ravnborg Suggested-by: Daniel Vetter Cc: Sean Paul Cc: Liviu Dudau Cc: Chris Wilson Cc: Maarten Lankhorst Cc: Maxim