Re: [PATCH v1 2/2] drm/i2c: tda998x: remove indirect reg_read/_write() calls

2019-06-21 Thread Russell King - ARM Linux admin
On Mon, May 27, 2019 at 03:15:52PM -0400, Sven Van Asbroeck wrote: > -static void > -reg_set(struct tda998x_priv *priv, u16 reg, u8 val) > +static int > +reg_set(struct regmap *regmap, u16 reg, u8 val) I don't see the point of making this return an 'int' - you don't modify any of the callsites to

[PATCH v1 2/2] drm/i2c: tda998x: remove indirect reg_read/_write() calls

2019-05-27 Thread Sven Van Asbroeck
Remove indirect reg_read/_write() calls, and replace them with direct calls to regmap functions. For the sake of readability, keep the following indirect register access calls: - reg_set() - reg_clear() - reg_write16() Signed-off-by: Sven Van Asbroeck --- drivers/gpu/drm/i2c/tda998x_drv.c | 333