Re: [PATCH v1 2/2] drm/sprd: fix potential NULL dereference

2022-01-11 Thread Thomas Zimmermann
Hi, on the changes for platform_get_resource(), you can Acked-by: Thomas Zimmermann but see my comments below. Am 24.12.21 um 15:12 schrieb Kevin Tang: platform_get_resource() may fail and return NULL, so check it's value before using it. 'drm' could be null in sprd_drm_shutdown, and drm_wa

Re: [PATCH v1 2/2] drm/sprd: fix potential NULL dereference

2022-01-11 Thread Javier Martinez Canillas
On 12/24/21 15:12, Kevin Tang wrote: > platform_get_resource() may fail and return NULL, so check it's value > before using it. > > 'drm' could be null in sprd_drm_shutdown, and drm_warn maybe dereference > it, remove this warning log. > I would split this second change in a separate patch and ju

[PATCH v1 2/2] drm/sprd: fix potential NULL dereference

2021-12-24 Thread Kevin Tang
platform_get_resource() may fail and return NULL, so check it's value before using it. 'drm' could be null in sprd_drm_shutdown, and drm_warn maybe dereference it, remove this warning log. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/sprd_dpu.c | 3 +++