Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-24 Thread Daniel Thompson
On Sun, Jan 14, 2024 at 05:25:09PM +0200, Andy Shevchenko wrote: > Move OF table near to the user. > > While at it, drop comma at terminator entry. > > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-22 Thread Daniel Thompson
On Sun, Jan 21, 2024 at 03:49:23PM +0200, Andy Shevchenko wrote: > On Mon, Jan 15, 2024 at 09:22:19AM +0100, Javier Martinez Canillas wrote: > > Andy Shevchenko writes: > > ... > > > > + {} > > > > While at it, maybe add the { /* sentinel */ } convention to the last entry ? > > Maybe. Is it a comm

Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-21 Thread Andy Shevchenko
On Mon, Jan 15, 2024 at 09:22:19AM +0100, Javier Martinez Canillas wrote: > Andy Shevchenko writes: ... > > + {} > > While at it, maybe add the { /* sentinel */ } convention to the last entry ? Maybe. Is it a common for this subsystem? ... > Reviewed-by: Javier Martinez Canillas Thank yo

Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-15 Thread Javier Martinez Canillas
Andy Shevchenko writes: > Move OF table near to the user. > > While at it, drop comma at terminator entry. > > Signed-off-by: Andy Shevchenko > --- > drivers/video/backlight/hx8357.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/vi

[PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-14 Thread Andy Shevchenko
Move OF table near to the user. While at it, drop comma at terminator entry. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/back