RE: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-11-01 Thread Tian, Kevin
> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > Now that we have a reasonable separation of structs that follow > the subchannel and mdev lifecycles, there's no reason we can't > call the official vfio_alloc_device routine for our private data, > and behave like everyone else.

Re: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-10-20 Thread Jason Gunthorpe
On Wed, Oct 19, 2022 at 01:57:41PM -0400, Eric Farman wrote: > On Wed, 2022-10-19 at 14:15 -0300, Jason Gunthorpe wrote: > > On Wed, Oct 19, 2022 at 06:21:34PM +0200, Eric Farman wrote: > > > > >  /* > > >   * Initialize a vfio_device so it can be registered to vfio core. > > > - * > > > - * Only

Re: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-10-19 Thread Eric Farman
On Wed, 2022-10-19 at 14:15 -0300, Jason Gunthorpe wrote: > On Wed, Oct 19, 2022 at 06:21:34PM +0200, Eric Farman wrote: > > >  /* > >   * Initialize a vfio_device so it can be registered to vfio core. > > - * > > - * Only vfio-ccw driver should call this interface. > >   */ > >  int

Re: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-10-19 Thread Jason Gunthorpe
On Wed, Oct 19, 2022 at 06:21:34PM +0200, Eric Farman wrote: > /* > * Initialize a vfio_device so it can be registered to vfio core. > - * > - * Only vfio-ccw driver should call this interface. > */ > int vfio_init_device(struct vfio_device *device, struct device *dev, >

[PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-10-19 Thread Eric Farman
Now that we have a reasonable separation of structs that follow the subchannel and mdev lifecycles, there's no reason we can't call the official vfio_alloc_device routine for our private data, and behave like everyone else. Signed-off-by: Eric Farman --- drivers/s390/cio/vfio_ccw_drv.c | 29