Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-24 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/lsdc_debugfs.c +void lsdc_debugfs_init(struct drm_minor *minor) +{ +#ifdef CONFIG_DEBUG_FS + drm_debugfs_create_files(lsdc_debugfs_list, +ARRAY_SIZE(lsdc_debugfs_list),

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: +++ b/drivers/gpu/drm/loongson/lsdc_drv.h @@ -0,0 +1,324 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2022 Loongson Corporation + * We're in 2023, update the year across the files? OK, it just that we started to upstream this

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: +static const struct dev_pm_ops lsdc_pm_ops = { + .suspend = lsdc_pm_suspend, + .resume = lsdc_pm_resume, + .freeze = lsdc_pm_freeze, + .thaw = lsdc_pm_thaw, + .poweroff = lsdc_pm_freeze, + .restore = lsdc_pm_resume,

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: +static enum drm_mode_status +lsdc_mode_config_mode_valid(struct drm_device *ddev, + const struct drm_display_mode *mode) +{ + struct lsdc_device *ldev = to_lsdc(ddev); + const struct drm_format_info *info =

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/lsdc_drv.c +static const struct lsdc_desc dc_in_ls7a1000 = { + .chip = CHIP_LS7A1000, + .num_of_crtc = LSDC_NUM_CRTC, + .max_pixel_clk = 20, + .max_width = 2048, +

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: + val = lsdc_crtc_rreg32(ldev, LSDC_CRTC0_CFG_REG, index); + /* clear old dma step settings */ + val &= ~CFG_DMA_STEP_MASK; + + if (descp->chip == CHIP_LS7A2000) { + /* +* Using large dma step as

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-10 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: +static void lsdc_crtc_reset(struct drm_crtc *crtc) +{ + struct lsdc_display_pipe *dispipe = crtc_to_display_pipe(crtc); + struct drm_device *ddev = crtc->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + struct lsdc_crtc_state

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-10 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/lsdc_debugfs.c +void lsdc_debugfs_init(struct drm_minor *minor) +{ +#ifdef CONFIG_DEBUG_FS + drm_debugfs_create_files(lsdc_debugfs_list, +ARRAY_SIZE(lsdc_debugfs_list),

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-05 Thread Sui Jingfeng
On 2023/4/6 00:40, Sui Jingfeng wrote: Hi, On 2023/4/4 22:10, Emil Velikov wrote: Greetings Sui Jingfeng, I haven't been around drm-land for a while and this is the first driver I skim through in a few years. So take the following suggestions with a healthy pinch of salt. Hope that helps

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-05 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: Greetings Sui Jingfeng, I haven't been around drm-land for a while and this is the first driver I skim through in a few years. So take the following suggestions with a healthy pinch of salt. Hope that helps o/ Emil, we love your reviews, On Mon, 3

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-04 Thread Emil Velikov
Greetings Sui Jingfeng, I haven't been around drm-land for a while and this is the first driver I skim through in a few years. So take the following suggestions with a healthy pinch of salt. Hope that helps o/ On Mon, 3 Apr 2023 at 18:13, Sui Jingfeng wrote: > v7 -> v8: >1) Zero a

[PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-03 Thread Sui Jingfeng
Loongson display controller IP has been integrated in both Loongson north bridge chipsets(ls7a1000/ls7a2000) and SoCs(ls2k1000/ls2k2000), it has been included in Loongson self-made BMC products. This display controller is a PCI device in all of chips mentiond, it has two display pipes which