Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-16 Thread Jessica Zhang
On 5/16/2023 3:49 PM, Marijn Suijten wrote: On 2023-05-16 01:07:05, Dmitry Baryshkov wrote: On 16/05/2023 01:01, Marijn Suijten wrote: On 2023-05-15 13:29:21, Jessica Zhang wrote: Const, as requested elsewhere. But this function is not used anywhere in any of the series (because we repla

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-16 Thread Marijn Suijten
On 2023-05-15 17:59:14, Jessica Zhang wrote: > > The name is good, I'm just not too keen on it hiding the multiplication > > with msm_dsc_get_slice_per_intf() which is already also computed and > > available in DSI, and I assume DP too? > > Got it, I see why you want to make that change now. DP o

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-16 Thread Marijn Suijten
On 2023-05-16 01:07:05, Dmitry Baryshkov wrote: > > On 16/05/2023 01:01, Marijn Suijten wrote: > > On 2023-05-15 13:29:21, Jessica Zhang wrote: > > > >>> Const, as requested elsewhere. But this function is not used anywhere > >>> in any of the series (because we replaced the usages with more sen

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Jessica Zhang
On 5/15/2023 3:07 PM, Dmitry Baryshkov wrote: On 16/05/2023 01:01, Marijn Suijten wrote: On 2023-05-15 13:29:21, Jessica Zhang wrote: Const, as requested elsewhere.  But this function is not used anywhere in any of the series (because we replaced the usages with more sensible member accesse

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Jessica Zhang
On 5/15/2023 3:01 PM, Marijn Suijten wrote: On 2023-05-15 13:29:21, Jessica Zhang wrote: Const, as requested elsewhere. But this function is not used anywhere in any of the series (because we replaced the usages with more sensible member accesses like slice_chunk_size). Acked. I would pr

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Dmitry Baryshkov
On 16/05/2023 01:01, Marijn Suijten wrote: On 2023-05-15 13:29:21, Jessica Zhang wrote: Const, as requested elsewhere. But this function is not used anywhere in any of the series (because we replaced the usages with more sensible member accesses like slice_chunk_size). Acked. I would prefer

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Marijn Suijten
On 2023-05-15 13:29:21, Jessica Zhang wrote: > > Const, as requested elsewhere. But this function is not used anywhere > > in any of the series (because we replaced the usages with more sensible > > member accesses like slice_chunk_size). > > Acked. > > I would prefer to keep this helper so tha

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Jessica Zhang
On 5/14/2023 2:25 PM, Marijn Suijten wrote: On 2023-05-12 14:32:14, Jessica Zhang wrote: Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_dsc_helper.h | 65 +

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-14 Thread Marijn Suijten
On 2023-05-12 14:32:14, Jessica Zhang wrote: > > Introduce MSM-specific DSC helper methods, as some calculations are > common between DP and DSC. > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/msm_dsc_helper.h | 65 > > 1 file changed, 65 inse

[PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-12 Thread Jessica Zhang
Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_dsc_helper.h | 65 1 file changed, 65 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_dsc_helper.h b/d