RE: [PATCH v2] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence

2021-12-14 Thread Huang, Ray
AM To: Huang, Ray ; dri-devel@lists.freedesktop.org; Koenig, Christian ; Daniel Vetter ; Sumit Semwal Cc: Deucher, Alexander ; amd-...@lists.freedesktop.org; Liu, Monk ; linux-me...@vger.kernel.org Subject: Re: [PATCH v2] drm/amdgpu: introduce new amdgpu_fence object to indicate the job emb

RE: [PATCH v2] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence

2021-12-14 Thread Huang, Ray
Deucher, > Alexander ; Liu, Monk > > Subject: Re: [PATCH v2] drm/amdgpu: introduce new amdgpu_fence object > to indicate the job embedded fence > > > > Am 14.12.21 um 12:15 schrieb Huang Rui: > > The job embedded fence donesn't initialize the flags

Re: [PATCH v2] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence

2021-12-14 Thread Andrey Grodzovsky
On 2021-12-14 12:03 p.m., Andrey Grodzovsky wrote: - -    if (job != NULL) { -    /* mark this fence has a parent job */ -    set_bit(AMDGPU_FENCE_FLAG_EMBED_IN_JOB_BIT, &fence->flags); +    if (job) +    dma_fence_init(fence, &amdgpu_job_fence_ops, +   &r

Re: [PATCH v2] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence

2021-12-14 Thread Andrey Grodzovsky
On 2021-12-14 6:15 a.m., Huang Rui wrote: The job embedded fence donesn't initialize the flags at dma_fence_init(). Then we will go a wrong way in amdgpu_fence_get_timeline_name callback and trigger a null pointer panic once we enabled the trace event here. So introduce new amdgpu_fence object

Re: [PATCH v2] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence

2021-12-14 Thread Christian König
Am 14.12.21 um 12:15 schrieb Huang Rui: The job embedded fence donesn't initialize the flags at dma_fence_init(). Then we will go a wrong way in amdgpu_fence_get_timeline_name callback and trigger a null pointer panic once we enabled the trace event here. So introduce new amdgpu_fence object t

[PATCH v2] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence

2021-12-14 Thread Huang Rui
The job embedded fence donesn't initialize the flags at dma_fence_init(). Then we will go a wrong way in amdgpu_fence_get_timeline_name callback and trigger a null pointer panic once we enabled the trace event here. So introduce new amdgpu_fence object to indicate the job embedded fence. [ 156.13