Re: [PATCH v2] drm/arm/comeda: don't use confusing 'timeout' variable name

2024-05-07 Thread Wolfram Sang
> I will change the subject line to s/comeda/komeda/ when merging it. Oh, thank you! signature.asc Description: PGP signature

Re: [PATCH v2] drm/arm/comeda: don't use confusing 'timeout' variable name

2024-05-07 Thread Liviu Dudau
On Tue, May 07, 2024 at 11:02:01AM +0200, Wolfram Sang wrote: > There is a confusing pattern in the kernel to use a variable named 'timeout' > to > store the result of wait_for_completion_timeout() causing patterns like: > > timeout = wait_for_completion_timeout(...) > if (!timeout)

[PATCH v2] drm/arm/comeda: don't use confusing 'timeout' variable name

2024-05-07 Thread Wolfram Sang
There is a confusing pattern in the kernel to use a variable named 'timeout' to store the result of wait_for_completion_timeout() causing patterns like: timeout = wait_for_completion_timeout(...) if (!timeout) return -ETIMEDOUT; with all kinds of permutations. Check the return