Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-02 Thread Manasi Navare
On Mon, Mar 02, 2020 at 09:15:27AM -0500, Kazlauskas, Nicholas wrote: > On 2020-02-28 9:38 p.m., Manasi Navare wrote: > >On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: > >>On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > >>>On Tue, Jan 07, 2020 at 04:32:08PM -0800,

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-02 Thread Kazlauskas, Nicholas
On 2020-02-28 9:38 p.m., Manasi Navare wrote: On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: Adaptive Sync is a VESA feature so add a DRM core helper

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-02-28 Thread Manasi Navare
On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: > On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > > the EDID's detailed

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-02-28 Thread Manasi Navare
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > > Store this info as

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Manasi Navare
On Tue, Jan 14, 2020 at 08:31:22AM -0500, Harry Wentland wrote: > Fixing Nick's email. > > On 2020-01-10 5:43 p.m., Manasi Navare wrote: > > On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: > >> On Tue, 07 Jan 2020, Manasi Navare wrote: > >>> Adaptive Sync is a VESA feature so add a

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Manasi Navare
On Tue, Jan 14, 2020 at 03:07:56PM +0200, Ville Syrjälä wrote: > On Mon, Jan 13, 2020 at 04:39:00PM -0800, Manasi Navare wrote: > > Hi Ville, > > > > So the two major changes you would like to see here are: > > > > use version_greate(edid) function > > and make use of : > >

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Jani Nikula
On Tue, 14 Jan 2020, Harry Wentland wrote: > Fixing Nick's email. > > On 2020-01-10 5:43 p.m., Manasi Navare wrote: >> On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: >>> On Tue, 07 Jan 2020, Manasi Navare wrote: +EXPORT_SYMBOL(drm_get_adaptive_sync_limits); >>> >>> Why the

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Harry Wentland
Fixing Nick's email. On 2020-01-10 5:43 p.m., Manasi Navare wrote: > On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: >> On Tue, 07 Jan 2020, Manasi Navare wrote: >>> Adaptive Sync is a VESA feature so add a DRM core helper to parse >>> the EDID's detailed descritors to obtain the

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Ville Syrjälä
On Mon, Jan 13, 2020 at 04:39:00PM -0800, Manasi Navare wrote: > Hi Ville, > > So the two major changes you would like to see here are: > > use version_greate(edid) function > and make use of : > drm_for_each_detailed_block() instead of the for loop. > But this function does not parse the

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-13 Thread Manasi Navare
Hi Ville, So the two major changes you would like to see here are: use version_greate(edid) function and make use of : drm_for_each_detailed_block() instead of the for loop. But this function does not parse the monitor range yet so you are suggesting modifying that dmr helper function as well?

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-10 Thread Manasi Navare
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > > Store this info as

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-10 Thread Manasi Navare
On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: > On Tue, 07 Jan 2020, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > > Store this info as part fo

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-09 Thread Jani Nikula
On Tue, 07 Jan 2020, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this info as part fo drm_display_info so it can be used > across all drivers. > This part of the code

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-09 Thread Ville Syrjälä
On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this info as part fo drm_display_info so it can be used > across all drivers. >

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-08 Thread Manasi Navare
Ville, could you take a look at this patch? I have tested this on the VRR monitor here and it does parse the detailed monitor range correctly to expose the min and max vfreq. Also I got rid of storing the pixel clock in the info->adaptive_sync_limits struct since thats just themax dotclock and

[PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-07 Thread Manasi Navare
Adaptive Sync is a VESA feature so add a DRM core helper to parse the EDID's detailed descritors to obtain the adaptive sync monitor range. Store this info as part fo drm_display_info so it can be used across all drivers. This part of the code is stripped out of amdgpu's function