RE: [PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2020-01-06 Thread Lin, Wayne
kernel.org > Subject: Re: [PATCH v2] drm/dp_mst: correct the shifting in > DP_REMOTE_I2C_READ > > Oh! Just a friendly tip, I fixed this before pushing your patch: > > ➜ drm-maint git:(drm-misc-fixes) dim push > dim: 0b1d54cedbb4 ("drm/dp_mst: correct the shifting in >

Re: [PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2020-01-03 Thread Lyude Paul
Oh! Just a friendly tip, I fixed this before pushing your patch: ➜ drm-maint git:(drm-misc-fixes) dim push dim: 0b1d54cedbb4 ("drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ"): Fixes: SHA1 needs at least 12 digits: dim: ad7f8a1f9ce (drm/helper: add Displayport multi-stream helper

Re: [PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2020-01-03 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks for all of the contributions you've made as of late! I will go ahead and push this into drm-misc-fixes On Fri, 2020-01-03 at 13:50 +0800, Wayne Lin wrote: > [Why] > According to DP spec, it should shift left 4 digits for NO_STOP_BIT > in REMOTE_I2C_READ message.

Re: [PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2020-01-03 Thread Harry Wentland
On 2020-01-03 12:50 a.m., Wayne Lin wrote: > [Why] > According to DP spec, it should shift left 4 digits for NO_STOP_BIT > in REMOTE_I2C_READ message. Not 5 digits. > > In current code, NO_STOP_BIT is always set to zero which means I2C > master is always generating a I2C stop at the end of each

[PATCH v2] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2020-01-02 Thread Wayne Lin
[Why] According to DP spec, it should shift left 4 digits for NO_STOP_BIT in REMOTE_I2C_READ message. Not 5 digits. In current code, NO_STOP_BIT is always set to zero which means I2C master is always generating a I2C stop at the end of each I2C write transaction while handling REMOTE_I2C_READ