Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-04-05 Thread Andrzej Hajda
On 31.03.2023 16:16, Andrzej Hajda wrote: From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm

Re: [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-04-04 Thread Andi Shyti
Hi, On Fri, Mar 31, 2023 at 04:16:36PM +0200, Andrzej Hajda wrote: > From: Chris Wilson > > There may be a disconnect between the GT used by the engine and the GT > used for the VM, requiring us to hold a wakeref on both while the GPU is > active with this request. > > v2: added explanation to

Re: [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-04-04 Thread Tvrtko Ursulin
On 04/04/2023 17:00, Andi Shyti wrote: Hi Tvrtko, diff --git a/drivers/gpu/drm/i915/gt/intel_context.h b/drivers/gpu/drm/i915/gt/intel_context.h index 0a8d553da3f439..48f888c3da083b 100644 --- a/drivers/gpu/drm/i915/gt/intel_context.h +++ b/drivers/gpu/drm/i915/gt/intel_context.h @@ -14,6

Re: [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-04-04 Thread Andi Shyti
Hi Tvrtko, > > > diff --git a/drivers/gpu/drm/i915/gt/intel_context.h > > > b/drivers/gpu/drm/i915/gt/intel_context.h > > > index 0a8d553da3f439..48f888c3da083b 100644 > > > --- a/drivers/gpu/drm/i915/gt/intel_context.h > > > +++ b/drivers/gpu/drm/i915/gt/intel_context.h > > > @@ -14,6 +14,7 @@

Re: [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-04-04 Thread Tvrtko Ursulin
On 04/04/2023 16:39, Andi Shyti wrote: Hi Andrzej, diff --git a/drivers/gpu/drm/i915/gt/intel_context.h b/drivers/gpu/drm/i915/gt/intel_context.h index 0a8d553da3f439..48f888c3da083b 100644 --- a/drivers/gpu/drm/i915/gt/intel_context.h +++ b/drivers/gpu/drm/i915/gt/intel_context.h @@ -14,6

Re: [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-04-04 Thread Andi Shyti
Hi Andrzej, > diff --git a/drivers/gpu/drm/i915/gt/intel_context.h > b/drivers/gpu/drm/i915/gt/intel_context.h > index 0a8d553da3f439..48f888c3da083b 100644 > --- a/drivers/gpu/drm/i915/gt/intel_context.h > +++ b/drivers/gpu/drm/i915/gt/intel_context.h > @@ -14,6 +14,7 @@ > #include

Re: [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-03-31 Thread Tvrtko Ursulin
On 31/03/2023 15:16, Andrzej Hajda wrote: From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm

[PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-03-31 Thread Andrzej Hajda
From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm Signed-off-by: Chris Wilson [ahajda: removed