Re: [PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

2023-01-27 Thread Chun-Kuang Hu
Hi, Nicolas: Nícolas F. R. A. Prado 於 2022年11月22日 週二 下午10:39寫道: > > mtk_drm_bind() can fail, in which case drm_dev_put() is called, > destroying the drm_device object. However a pointer to it was still > being held in the private object, and that pointer would be passed along > to DRM in mtk_drm_

Re: [PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

2022-11-28 Thread AngeloGioacchino Del Regno
Il 25/11/22 17:34, Nícolas F. R. A. Prado ha scritto: On Wed, Nov 23, 2022 at 10:15:25AM +0100, AngeloGioacchino Del Regno wrote: Il 22/11/22 15:39, Nícolas F. R. A. Prado ha scritto: mtk_drm_bind() can fail, in which case drm_dev_put() is called, destroying the drm_device object. However a poi

Re: [PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

2022-11-25 Thread Nícolas F . R . A . Prado
On Wed, Nov 23, 2022 at 10:15:25AM +0100, AngeloGioacchino Del Regno wrote: > Il 22/11/22 15:39, Nícolas F. R. A. Prado ha scritto: > > mtk_drm_bind() can fail, in which case drm_dev_put() is called, > > destroying the drm_device object. However a pointer to it was still > > being held in the priva

Re: [PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

2022-11-23 Thread AngeloGioacchino Del Regno
Il 22/11/22 15:39, Nícolas F. R. A. Prado ha scritto: mtk_drm_bind() can fail, in which case drm_dev_put() is called, destroying the drm_device object. However a pointer to it was still being held in the private object, and that pointer would be passed along to DRM in mtk_drm_sys_prepare() if a s

[PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

2022-11-22 Thread Nícolas F . R . A . Prado
mtk_drm_bind() can fail, in which case drm_dev_put() is called, destroying the drm_device object. However a pointer to it was still being held in the private object, and that pointer would be passed along to DRM in mtk_drm_sys_prepare() if a suspend were triggered at that point, resulting in a pani