Re: [PATCH v2] drm/vkms: add module parameter to set background color

2023-04-11 Thread Maíra Canal
On 4/11/23 05:58, Simon Ser wrote: Hi, On Monday, April 10th, 2023 at 19:50, Melissa Wen wrote: On 04/10, Simon Ser wrote: I think this should be a KMS property instead of a module parameter. Is there a reason why this patch uses a module parameter? It breaks user-space expectations. a KM

Re: [PATCH v2] drm/vkms: add module parameter to set background color

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 08:58:16AM +, Simon Ser wrote: > Hi, > > On Monday, April 10th, 2023 at 19:50, Melissa Wen wrote: > > > On 04/10, Simon Ser wrote: > > > > > I think this should be a KMS property instead of a module parameter. > > > Is there a reason why this patch uses a module para

Re: [PATCH v2] drm/vkms: add module parameter to set background color

2023-04-11 Thread Simon Ser
Hi, On Monday, April 10th, 2023 at 19:50, Melissa Wen wrote: > On 04/10, Simon Ser wrote: > > > I think this should be a KMS property instead of a module parameter. > > Is there a reason why this patch uses a module parameter? It breaks > > user-space expectations. > > a KMS property is what w

Re: [PATCH v2] drm/vkms: add module parameter to set background color

2023-04-10 Thread Melissa Wen
On 04/10, Simon Ser wrote: > I think this should be a KMS property instead of a module parameter. > Is there a reason why this patch uses a module parameter? It breaks > user-space expectations. Hi Simon, a KMS property is what we have on vkms TODO [1] and the module parameter was Maíra's first s

Re: [PATCH v2] drm/vkms: add module parameter to set background color

2023-04-10 Thread Simon Ser
I think this should be a KMS property instead of a module parameter. Is there a reason why this patch uses a module parameter? It breaks user-space expectations.

[PATCH v2] drm/vkms: add module parameter to set background color

2023-04-10 Thread Maíra Canal
After commit 8ba1648567e2 ("drm: vkms: Refactor the plane composer to accept new formats") the composition is no longer performed on top of the primary plane, but instead on top of the CRTC, which means that now we have a background. This opens to the possibility of coloring the background with a