Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-14 Thread Wentland, Harry
On 2019-01-07 12:41 p.m., Nicholas Kazlauskas wrote: > The prepare_fb call always happens on new_plane_state. > > The drm_atomic_helper_cleanup_planes checks to see if > plane state pointer has changed when deciding to call cleanup_fb on > either the new_plane_state or the old_plane_state. > > Fo

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-14 Thread Helen Koike via dri-devel
On 2/14/19 6:21 AM, Daniel Vetter wrote: > On Wed, Feb 13, 2019 at 09:32:43PM -0200, Helen Koike wrote: >> >> >> On 2/13/19 7:21 PM, Helen Koike wrote: >>> >>> >>> On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: The prepare_fb call always happens on new_plane_state. The drm_atomic_h

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-14 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 09:32:43PM -0200, Helen Koike wrote: > > > On 2/13/19 7:21 PM, Helen Koike wrote: > > > > > > On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: > >> The prepare_fb call always happens on new_plane_state. > >> > >> The drm_atomic_helper_cleanup_planes checks to see if > >> p

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-13 Thread Helen Koike via dri-devel
On 2/13/19 7:21 PM, Helen Koike wrote: > > > On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: >> The prepare_fb call always happens on new_plane_state. >> >> The drm_atomic_helper_cleanup_planes checks to see if >> plane state pointer has changed when deciding to call cleanup_fb on >> either the

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-13 Thread Helen Koike via dri-devel
On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: > The prepare_fb call always happens on new_plane_state. > > The drm_atomic_helper_cleanup_planes checks to see if > plane state pointer has changed when deciding to call cleanup_fb on > either the new_plane_state or the old_plane_state. > > For a

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-01-07 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: fef9df8b5945 drm/atomic: initial support for asynchronous plane update. The bot has tested the following trees: v4.20.0, v4.19.13, v4.14.91. v4.20.0: Build OK! v4.19.13: Build OK!

[PATCH v2] drm: Block fb changes for async plane updates

2019-01-07 Thread Nicholas Kazlauskas
The prepare_fb call always happens on new_plane_state. The drm_atomic_helper_cleanup_planes checks to see if plane state pointer has changed when deciding to call cleanup_fb on either the new_plane_state or the old_plane_state. For a non-async atomic commit the state pointer is swapped, so this h