Re: [PATCH v2 00/22]drm/msm/dpu: another catalog rework

2023-06-15 Thread Marijn Suijten
On 2023-06-15 14:31:22, Dmitry Baryshkov wrote: > > On Tue, 13 Jun 2023 03:09:39 +0300, Dmitry Baryshkov wrote: > > Having a macro with 10 arguments doesn't seem like a good idea. It makes > > it inherently harder to compare the actual structure values. Also this > > leads to adding macros

Re: [PATCH v2 00/22]drm/msm/dpu: another catalog rework

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:39, Dmitry Baryshkov wrote: > Having a macro with 10 arguments doesn't seem like a good idea. It makes > it inherently harder to compare the actual structure values. Also this > leads to adding macros covering varieties of the block. > > As it was previously discussed, inline

Re: [PATCH v2 00/22]drm/msm/dpu: another catalog rework

2023-06-15 Thread Dmitry Baryshkov
On Tue, 13 Jun 2023 03:09:39 +0300, Dmitry Baryshkov wrote: > Having a macro with 10 arguments doesn't seem like a good idea. It makes > it inherently harder to compare the actual structure values. Also this > leads to adding macros covering varieties of the block. > > As it was previously

[PATCH v2 00/22]drm/msm/dpu: another catalog rework

2023-06-12 Thread Dmitry Baryshkov
Having a macro with 10 arguments doesn't seem like a good idea. It makes it inherently harder to compare the actual structure values. Also this leads to adding macros covering varieties of the block. As it was previously discussed, inline all foo_BLK macros in order to ease performing changes to