Re: [PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-22 Thread Andi Shyti
Hi Mauro, On Thu, Jul 14, 2022 at 01:06:06PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Check if the device is powered down prior to any engine activity, > as, on such cases, all the TLBs were already invalidated, so an > explicit TLB invalidation is not needed, thus reducing

RE: [Intel-gfx] [PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-19 Thread David Laight
From: Tvrtko Ursulin > Sent: 19 July 2022 08:25 ... > > It's not only the TLB flushes that cause grief. > > > > There is a loop that forces a write-back of all the frame buffer pages. > > With a large display and some cpu (like my Ivy bridge one) that > > takes long enough with pre-emption

Re: [Intel-gfx] [PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-19 Thread Tvrtko Ursulin
Hi David, On 18/07/2022 16:50, David Laight wrote: From: Mauro Carvalho Chehab Sent: 18 July 2022 15:54 On Mon, 18 Jul 2022 14:16:10 +0100 Tvrtko Ursulin wrote: On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: From: Chris Wilson Check if the device is powered down prior to any engine

RE: [Intel-gfx] [PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-18 Thread David Laight
From: Mauro Carvalho Chehab > Sent: 18 July 2022 15:54 > > On Mon, 18 Jul 2022 14:16:10 +0100 > Tvrtko Ursulin wrote: > > > On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: > > > From: Chris Wilson > > > > > > Check if the device is powered down prior to any engine activity, > > > as, on such

Re: [Intel-gfx] [PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-18 Thread Tvrtko Ursulin
On 18/07/2022 15:53, Mauro Carvalho Chehab wrote: On Mon, 18 Jul 2022 14:16:10 +0100 Tvrtko Ursulin wrote: On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: From: Chris Wilson Check if the device is powered down prior to any engine activity, as, on such cases, all the TLBs were already

Re: [Intel-gfx] [PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-18 Thread Mauro Carvalho Chehab
On Mon, 18 Jul 2022 14:16:10 +0100 Tvrtko Ursulin wrote: > On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: > > From: Chris Wilson > > > > Check if the device is powered down prior to any engine activity, > > as, on such cases, all the TLBs were already invalidated, so an > > explicit TLB

Re: [PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-18 Thread Tvrtko Ursulin
On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: From: Chris Wilson Check if the device is powered down prior to any engine activity, as, on such cases, all the TLBs were already invalidated, so an explicit TLB invalidation is not needed, thus reducing the performance regression impact due

[PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson Check if the device is powered down prior to any engine activity, as, on such cases, all the TLBs were already invalidated, so an explicit TLB invalidation is not needed, thus reducing the performance regression impact due to it. This becomes more significant with GuC, as it