Re: [PATCH v2 05/12] drm/panfrost: Disable the AS on unhandled page faults

2021-06-21 Thread Boris Brezillon
On Mon, 21 Jun 2021 16:09:32 +0100 Steven Price wrote: > On 21/06/2021 14:39, Boris Brezillon wrote: > > If we don't do that, we have to wait for the job timeout to expire > > before the fault jobs gets killed. > > > > Signed-off-by: Boris Brezillon > > Don't we need to do something here to

Re: [PATCH v2 05/12] drm/panfrost: Disable the AS on unhandled page faults

2021-06-21 Thread Steven Price
On 21/06/2021 14:39, Boris Brezillon wrote: > If we don't do that, we have to wait for the job timeout to expire > before the fault jobs gets killed. > > Signed-off-by: Boris Brezillon Don't we need to do something here to allow recovery of the MMU context in the future? panfrost_mmu_disable() w

Re: [PATCH v2 05/12] drm/panfrost: Disable the AS on unhandled page faults

2021-06-21 Thread Boris Brezillon
On Mon, 21 Jun 2021 15:39:00 +0200 Boris Brezillon wrote: > If we don't do that, we have to wait for the job timeout to expire > before the fault jobs gets killed. ^ faulty > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 +- > 1 file ch

[PATCH v2 05/12] drm/panfrost: Disable the AS on unhandled page faults

2021-06-21 Thread Boris Brezillon
If we don't do that, we have to wait for the job timeout to expire before the fault jobs gets killed. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/dri