Re: [PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-26 Thread Maxime Ripard
Hi Ville, On Fri, Jan 22, 2021 at 02:15:07PM +0200, Ville Syrjälä wrote: > On Thu, Jan 21, 2021 at 05:35:33PM +0100, Maxime Ripard wrote: > > Some drivers are storing the plane->state pointer in atomic_update and > > atomic_disable in a variable simply called state, while the state passed > > as

Re: [PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-25 Thread Ville Syrjälä
On Mon, Jan 25, 2021 at 11:52:18AM +0100, Maxime Ripard wrote: > Hi Ville, > > On Fri, Jan 22, 2021 at 02:15:07PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 21, 2021 at 05:35:33PM +0100, Maxime Ripard wrote: > > > Some drivers are storing the plane->state pointer in atomic_update and > > >

Re: [PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-22 Thread Ville Syrjälä
On Thu, Jan 21, 2021 at 05:35:33PM +0100, Maxime Ripard wrote: > Some drivers are storing the plane->state pointer in atomic_update and > atomic_disable in a variable simply called state, while the state passed > as an argument is called old_state. > > In order to ease subsequent reworks and to

[PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-22 Thread Maxime Ripard
Some drivers are storing the plane->state pointer in atomic_update and atomic_disable in a variable simply called state, while the state passed as an argument is called old_state. In order to ease subsequent reworks and to avoid confusing or inconsistent names, let's rename those variables to