[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-06-08 Thread Jon Hunter
Hi Boris, On 05/06/15 12:39, Boris Brezillon wrote: > Hi Jon, > > On Fri, 5 Jun 2015 09:46:09 +0100 > Jon Hunter wrote: > >> >> On 05/06/15 00:02, Paul Walmsley wrote: >>> Hi folks >>> >>> just a brief comment on this one: >>> >>> On Thu, 30 Apr 2015, Boris Brezillon wrote: >>> Clock

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-06-05 Thread Boris Brezillon
Hi Jon, On Fri, 5 Jun 2015 09:46:09 +0100 Jon Hunter wrote: > > On 05/06/15 00:02, Paul Walmsley wrote: > > Hi folks > > > > just a brief comment on this one: > > > > On Thu, 30 Apr 2015, Boris Brezillon wrote: > > > >> Clock rates are stored in an unsigned long field, but ->round_rate() >

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-06-05 Thread Boris Brezillon
Hi Paul, On Thu, 4 Jun 2015 23:02:25 + (UTC) Paul Walmsley wrote: > Hi folks > > just a brief comment on this one: > > On Thu, 30 Apr 2015, Boris Brezillon wrote: > > > Clock rates are stored in an unsigned long field, but ->round_rate() > > (which returns a rounded rate from a requested

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-06-05 Thread Jon Hunter
On 05/06/15 00:02, Paul Walmsley wrote: > Hi folks > > just a brief comment on this one: > > On Thu, 30 Apr 2015, Boris Brezillon wrote: > >> Clock rates are stored in an unsigned long field, but ->round_rate() >> (which returns a rounded rate from a requested one) returns a long >> value

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-06-05 Thread Paul Walmsley
Hi folks just a brief comment on this one: On Thu, 30 Apr 2015, Boris Brezillon wrote: > Clock rates are stored in an unsigned long field, but ->round_rate() > (which returns a rounded rate from a requested one) returns a long > value (errors are reported using negative error codes), which can

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-05-19 Thread Stephen Boyd
On 05/16, Mikko Perttunen wrote: > On 05/15/2015 06:40 PM, Boris Brezillon wrote: > >Hi Stephen, > > > >Adding Mikko in the loop (after all, he was the one complaining about > >this signed long limitation in the first place, and I forgot to add > >him in the Cc list :-/). > > I think I got it

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-05-16 Thread Mikko Perttunen
On 05/15/2015 06:40 PM, Boris Brezillon wrote: > Hi Stephen, > > Adding Mikko in the loop (after all, he was the one complaining about > this signed long limitation in the first place, and I forgot to add > him in the Cc list :-/). I think I got it through linux-tegra anyway, but thanks :) > >

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-05-15 Thread Boris Brezillon
Hi Stephen, Adding Mikko in the loop (after all, he was the one complaining about this signed long limitation in the first place, and I forgot to add him in the Cc list :-/). Mikko, are you okay with the approach proposed by Stephen (adding a new method) ? On Thu, 7 May 2015 09:37:02 +0200

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-05-07 Thread Boris Brezillon
Hi Stephen, On Wed, 6 May 2015 23:39:53 -0700 Stephen Boyd wrote: > On 04/30, Boris Brezillon wrote: > > Clock rates are stored in an unsigned long field, but ->round_rate() > > (which returns a rounded rate from a requested one) returns a long > > value (errors are reported using negative

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-05-07 Thread Stephen Boyd
On 04/30, Boris Brezillon wrote: > Clock rates are stored in an unsigned long field, but ->round_rate() > (which returns a rounded rate from a requested one) returns a long > value (errors are reported using negative error codes), which can lead > to long overflow if the clock rate exceed 2Ghz. >

[PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-04-30 Thread Boris Brezillon
Clock rates are stored in an unsigned long field, but ->round_rate() (which returns a rounded rate from a requested one) returns a long value (errors are reported using negative error codes), which can lead to long overflow if the clock rate exceed 2Ghz. Change ->round_rate() prototype to return