Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-17 Thread Tobias Jakobi
Hello Maxime, Maxime Ripard wrote: > Hi, > > On Thu, Feb 16, 2017 at 01:28:24PM +0100, Tobias Jakobi wrote: >> Hello, >> >> I'm not sure if I'm missing something here, but I don't see how this is >> supposed to work. >> >> This just multiplies the height of the drm_mode_fb_cmd2 object with the

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-17 Thread Laurent Pinchart
Hi Maxime, On Wednesday 15 Feb 2017 13:51:29 Maxime Ripard wrote: > On Tue, Feb 14, 2017 at 11:25:08PM +0200, Laurent Pinchart wrote: > > On Tuesday 14 Feb 2017 21:09:51 Daniel Vetter wrote: > >> On Mon, Feb 13, 2017 at 11:20:51AM +, Daniel Stone wrote: > >>> On 13 February 2017 at 10:54,

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-17 Thread Laurent Pinchart
Hi Maxime, On Wednesday 15 Feb 2017 13:38:44 Maxime Ripard wrote: > On Mon, Feb 13, 2017 at 11:20:51AM +, Daniel Stone wrote: > > On 13 February 2017 at 10:54, Maxime Ripard wrote: > >> On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: > >>> On Thursday 02 Feb 2017 11:31:56

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-17 Thread Maxime Ripard
Hi, On Thu, Feb 16, 2017 at 01:28:24PM +0100, Tobias Jakobi wrote: > Hello, > > I'm not sure if I'm missing something here, but I don't see how this is > supposed to work. > > This just multiplies the height of the drm_mode_fb_cmd2 object with the > number of buffers. Let's say I have

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-16 Thread Tobias Jakobi
Hello, I'm not sure if I'm missing something here, but I don't see how this is supposed to work. This just multiplies the height of the drm_mode_fb_cmd2 object with the number of buffers. Let's say I have width=1024, height=768, then now I have a framebuffer which has height=2304 (in the

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-15 Thread Maxime Ripard
Hi, On Tue, Feb 14, 2017 at 11:25:08PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Tuesday 14 Feb 2017 21:09:51 Daniel Vetter wrote: > > On Mon, Feb 13, 2017 at 11:20:51AM +, Daniel Stone wrote: > > > On 13 February 2017 at 10:54, Maxime Ripard wrote: > > >> On Sun, Feb 12, 2017 at

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-15 Thread Maxime Ripard
Hi, On Mon, Feb 13, 2017 at 11:20:51AM +, Daniel Stone wrote: > Hi Maxime, > > On 13 February 2017 at 10:54, Maxime Ripard > wrote: > > On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: > >> On Thursday 02 Feb 2017 11:31:56 Maxime Ripard

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-14 Thread Laurent Pinchart
Hi Daniel, On Tuesday 14 Feb 2017 21:09:51 Daniel Vetter wrote: > On Mon, Feb 13, 2017 at 11:20:51AM +, Daniel Stone wrote: > > On 13 February 2017 at 10:54, Maxime Ripard wrote: > >> On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: > >>> On Thursday 02 Feb 2017 11:31:56

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-14 Thread Daniel Vetter
On Mon, Feb 13, 2017 at 11:20:51AM +, Daniel Stone wrote: > Hi Maxime, > > On 13 February 2017 at 10:54, Maxime Ripard > wrote: > > On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: > >> On Thursday 02 Feb 2017 11:31:56 Maxime Ripard wrote: >

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-13 Thread Daniel Stone
Hi Maxime, On 13 February 2017 at 10:54, Maxime Ripard wrote: > On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: >> On Thursday 02 Feb 2017 11:31:56 Maxime Ripard wrote: >> > This patch add a config to support to create multi buffer for cma

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-13 Thread Maxime Ripard
Hi Laurent, On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Thursday 02 Feb 2017 11:31:56 Maxime Ripard wrote: > > From: Xinliang Liu > > > > This patch add a config to support to create multi buffer

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-12 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Thursday 02 Feb 2017 11:31:56 Maxime Ripard wrote: > From: Xinliang Liu > > This patch add a config to support to create multi buffer for cma fbdev. > Such as double buffer and triple buffer. > > Cma fbdev is convient to add a

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-10 Thread Maxime Ripard
Hi Daniel, On Thu, Feb 09, 2017 at 06:04:38PM +0100, Daniel Vetter wrote: > On Thu, Feb 02, 2017 at 11:31:56AM +0100, Maxime Ripard wrote: > > From: Xinliang Liu > > > > This patch add a config to support to create multi buffer for cma fbdev. > > Such as double buffer

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-09 Thread Daniel Vetter
On Thu, Feb 02, 2017 at 11:31:56AM +0100, Maxime Ripard wrote: > From: Xinliang Liu > > This patch add a config to support to create multi buffer for cma fbdev. > Such as double buffer and triple buffer. > > Cma fbdev is convient to add a legency fbdev. And still many

[PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-02 Thread Maxime Ripard
From: Xinliang Liu This patch add a config to support to create multi buffer for cma fbdev. Such as double buffer and triple buffer. Cma fbdev is convient to add a legency fbdev. And still many Android devices use fbdev now and at least double buffer is needed for these