Re: [PATCH v2 1/2] drm: add legacy support for using degamma for gamma

2020-12-09 Thread Tomi Valkeinen
Hi Daniel, On 09/12/2020 02:51, Daniel Vetter wrote: >>> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h >>> index ba839e5e357d..4d9e217e5040 100644 >>> --- a/include/drm/drm_crtc.h >>> +++ b/include/drm/drm_crtc.h >>> @@ -1084,6 +1084,9 @@ struct drm_crtc { >>> */ >>>

Re: [PATCH v2 1/2] drm: add legacy support for using degamma for gamma

2020-12-09 Thread Daniel Vetter
On Wed, Dec 9, 2020 at 12:17 PM Tomi Valkeinen wrote: > > Hi Daniel, > > On 09/12/2020 02:51, Daniel Vetter wrote: > > >>> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > >>> index ba839e5e357d..4d9e217e5040 100644 > >>> --- a/include/drm/drm_crtc.h > >>> +++

Re: [PATCH v2 1/2] drm: add legacy support for using degamma for gamma

2020-12-08 Thread Daniel Vetter
On Tue, Dec 08, 2020 at 05:55:11PM +0200, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Dec 08, 2020 at 03:57:58PM +0200, Tomi Valkeinen wrote: > > We currently have drm_atomic_helper_legacy_gamma_set() helper which can > > be used to handle legacy gamma-set ioctl.

[PATCH v2 1/2] drm: add legacy support for using degamma for gamma

2020-12-08 Thread Tomi Valkeinen
We currently have drm_atomic_helper_legacy_gamma_set() helper which can be used to handle legacy gamma-set ioctl. drm_atomic_helper_legacy_gamma_set() sets GAMMA_LUT, and clears CTM and DEGAMMA_LUT. This works fine on HW where we have either: degamma -> ctm -> gamma -> out or ctm -> gamma ->

Re: [PATCH v2 1/2] drm: add legacy support for using degamma for gamma

2020-12-08 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Dec 08, 2020 at 03:57:58PM +0200, Tomi Valkeinen wrote: > We currently have drm_atomic_helper_legacy_gamma_set() helper which can > be used to handle legacy gamma-set ioctl. > drm_atomic_helper_legacy_gamma_set() sets GAMMA_LUT, and clears > CTM and