Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: [...] config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + select FB_CORE >>> >>> This should depend on FB_CORE. >>> >> >> Yes, already fixed in v3 too. I did a select to prevent symbol circular >> dependencies bu

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-03 Thread Thomas Zimmermann
Hi Am 03.07.23 um 09:46 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Thanks for your review. Hi Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas: [...] +menuconfig FB_CORE + tristate "Core support for frame buffer devices" With the text, th

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-03 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, Thanks for your review. > Hi > > Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas: [...] >> >> +menuconfig FB_CORE >> +tristate "Core support for frame buffer devices" > > With the text, this is visible; as others noted. > Yes, I misremembe

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-02 Thread Thomas Zimmermann
Hi Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas: Currently the CONFIG_FB option has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles). The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB and so it can only

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-02 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > Hi Arnd, > [...] >> >> That would leave CONFIG_FB_DEVICE as the only user visible option >> for DRM-only configs, which is slightly odd for the menuconfig, >> so I still wonder if that could be done differently. >> >> Is there actually a point in configurations for

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-02 Thread Geert Uytterhoeven
Hi Arnd, On Sun, Jul 2, 2023 at 12:25 AM Arnd Bergmann wrote: > On Sat, Jul 1, 2023, at 23:44, Javier Martinez Canillas wrote: > > Currently the CONFIG_FB option has to be enabled even if no legacy fbdev > > drivers are needed (e.g: only to have support for framebuffer consoles). > > > > The DRM

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-01 Thread Arnd Bergmann
On Sat, Jul 1, 2023, at 23:44, Javier Martinez Canillas wrote: > Currently the CONFIG_FB option has to be enabled even if no legacy fbdev > drivers are needed (e.g: only to have support for framebuffer consoles). > > The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB > and so i

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-01 Thread Randy Dunlap
Hi, Does this series apply on top of the previous series or on what? On 7/1/23 14:44, Javier Martinez Canillas wrote: > Currently the CONFIG_FB option has to be enabled even if no legacy fbdev > drivers are needed (e.g: only to have support for framebuffer consoles). > > The DRM subsystem has

[PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-01 Thread Javier Martinez Canillas
Currently the CONFIG_FB option has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles). The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB and so it can only be enabled if that dependency is enabled as well. That means