Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-09 Thread Tvrtko Ursulin
On 08/01/2024 15:13, Joonas Lahtinen wrote: Quoting Tvrtko Ursulin (2024-01-05 12:39:31) On 04/01/2024 21:23, Andi Shyti wrote: +void intel_gt_apply_ccs_mode(struct intel_gt *gt) +{ + mutex_lock(>->ccs.mutex); + __intel_gt_apply_ccs_mode(gt); + mutex_unlock(>->ccs.mutex); +} + +voi

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-08 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2024-01-05 12:39:31) > > On 04/01/2024 21:23, Andi Shyti wrote: > >>> +void intel_gt_apply_ccs_mode(struct intel_gt *gt) > >>> +{ > >>> + mutex_lock(>->ccs.mutex); > >>> + __intel_gt_apply_ccs_mode(gt); > >>> + mutex_unlock(>->ccs.mutex); > >>> +} > >>> + > >>> +vo

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-05 Thread Tvrtko Ursulin
On 04/01/2024 21:23, Andi Shyti wrote: Hi Tvrtko, [1] + /* +* Loop over all available slices and assign each a user engine. +* +* With 1 engine (ccs0): +* slice 0, 1, 2, 3: ccs0 +* +* With 2 engines (ccs0, ccs1): +* slice 0, 2

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Andi Shyti
Hi Tvrtko, [1] > > + /* > > +* Loop over all available slices and assign each a user engine. > > +* > > +* With 1 engine (ccs0): > > +* slice 0, 1, 2, 3: ccs0 > > +* > > +* With 2 engines (ccs0, ccs1): > > +* slice 0, 2: ccs0 > > +* slice 1, 3: ccs1 > > +

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Tvrtko Ursulin
On 04/01/2024 14:35, Andi Shyti wrote: The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one

[PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Andi Shyti
The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one CCS to all the slices. Based on a patch by