Re: [Freedreno] [PATCH v2 1/3] drm/msm/dpu: Move LM CRC code into separate method

2022-06-15 Thread Jessica Zhang
On 6/15/2022 9:17 AM, Dmitry Baryshkov wrote: On 15/06/2022 19:11, Jessica Zhang wrote: On 6/15/2022 2:35 AM, Dmitry Baryshkov wrote: On Wed, 15 Jun 2022 at 00:13, Jessica Zhang wrote: Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can

Re: [PATCH v2 1/3] drm/msm/dpu: Move LM CRC code into separate method

2022-06-15 Thread Dmitry Baryshkov
On 15/06/2022 19:11, Jessica Zhang wrote: On 6/15/2022 2:35 AM, Dmitry Baryshkov wrote: On Wed, 15 Jun 2022 at 00:13, Jessica Zhang wrote: Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can make it easier to get CRCs from other HW blocks

Re: [PATCH v2 1/3] drm/msm/dpu: Move LM CRC code into separate method

2022-06-15 Thread Jessica Zhang
On 6/15/2022 2:35 AM, Dmitry Baryshkov wrote: On Wed, 15 Jun 2022 at 00:13, Jessica Zhang wrote: Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can make it easier to get CRCs from other HW blocks by adding other get_crc helper methods.

Re: [PATCH v2 1/3] drm/msm/dpu: Move LM CRC code into separate method

2022-06-15 Thread Dmitry Baryshkov
On Wed, 15 Jun 2022 at 00:13, Jessica Zhang wrote: > > Move layer mixer-specific section of dpu_crtc_get_crc() into a separate > helper method. This way, we can make it easier to get CRCs from other HW > blocks by adding other get_crc helper methods. > > Changes since V1: > - Moved common

[PATCH v2 1/3] drm/msm/dpu: Move LM CRC code into separate method

2022-06-14 Thread Jessica Zhang
Move layer mixer-specific section of dpu_crtc_get_crc() into a separate helper method. This way, we can make it easier to get CRCs from other HW blocks by adding other get_crc helper methods. Changes since V1: - Moved common bitmasks to dpu_hw_util.h - Moved common CRC methods to dpu_hw_util.c -