Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-15 Thread Daniel Vetter
On Thu, Mar 14, 2019 at 12:44:06PM +, Kazlauskas, Nicholas wrote: > On 3/14/19 5:50 AM, Daniel Vetter wrote: > > On Wed, Mar 13, 2019 at 05:41:52PM +, Kazlauskas, Nicholas wrote: > >> On 3/13/19 1:33 PM, Michel Dänzer wrote: > >>> On 2019-03-13 5:16 p.m., Kazlauskas, Nicholas wrote: >

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-15 Thread Daniel Vetter
On Thu, Mar 14, 2019 at 10:52:08AM +0100, John Ogness wrote: > On 2019-03-14, John Ogness wrote: > > On 2019-03-14, Daniel Vetter wrote: > >> That's why we came up with the trylock + immediate bail out design if > >> that fails. Plus really only render the oops int whatever is the > >> current

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-15 Thread John Ogness
On 2019-03-14, John Ogness wrote: > On 2019-03-14, Daniel Vetter wrote: >> That's why we came up with the trylock + immediate bail out design if >> that fails. Plus really only render the oops int whatever is the >> current display buffer, so that we don't have to do any hw >> programming at

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-15 Thread John Ogness
On 2019-03-14, Daniel Vetter wrote: > That's why we came up with the trylock + immediate bail out design if > that fails. Plus really only render the oops int whatever is the > current display buffer, so that we don't have to do any hw programming > at all. I think this is your best option. The

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-14 Thread Kazlauskas, Nicholas
On 3/14/19 5:50 AM, Daniel Vetter wrote: > On Wed, Mar 13, 2019 at 05:41:52PM +, Kazlauskas, Nicholas wrote: >> On 3/13/19 1:33 PM, Michel Dänzer wrote: >>> On 2019-03-13 5:16 p.m., Kazlauskas, Nicholas wrote: On 3/13/19 11:54 AM, Christian König wrote: > Am 13.03.19 um 16:38 schrieb

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-14 Thread Daniel Vetter
On Wed, Mar 13, 2019 at 05:41:52PM +, Kazlauskas, Nicholas wrote: > On 3/13/19 1:33 PM, Michel Dänzer wrote: > > On 2019-03-13 5:16 p.m., Kazlauskas, Nicholas wrote: > >> On 3/13/19 11:54 AM, Christian König wrote: > >>> Am 13.03.19 um 16:38 schrieb Michel Dänzer: > On 2019-03-13 2:37

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-14 Thread Daniel Vetter
On Wed, Mar 13, 2019 at 04:54:50PM +0100, Christian König wrote: > Am 13.03.19 um 16:38 schrieb Michel Dänzer: > > On 2019-03-13 2:37 p.m., Christian König wrote: > > > Am 13.03.19 um 14:31 schrieb Ville Syrjälä: > > > > On Wed, Mar 13, 2019 at 10:35:08AM +0100, Michel Dänzer wrote: > > > > > On

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-14 Thread Daniel Vetter
On Thu, Mar 14, 2019 at 05:45:32AM +0100, Ahmed S. Darwish wrote: > Hi, > > On Wed, Mar 13, 2019 at 09:35:05AM +0100, Daniel Vetter wrote: > > On Tue, Mar 12, 2019 at 11:13:03PM +0100, Ahmed S. Darwish wrote: > > > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > > Den

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-14 Thread Daniel Vetter
On Thu, Mar 14, 2019 at 03:51:13AM +0100, Ahmed S. Darwish wrote: > > [[ Adding Sebastian, who is quite experienced in intricate >locking situations due to daily PREEMPT_RT work.. ]] > > On Wed, Mar 13, 2019 at 09:37:10AM +0100, Daniel Vetter wrote: > > On Wed, Mar 13, 2019 at 08:49:17AM

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Ahmed S. Darwish
Hi, On Wed, Mar 13, 2019 at 09:35:05AM +0100, Daniel Vetter wrote: > On Tue, Mar 12, 2019 at 11:13:03PM +0100, Ahmed S. Darwish wrote: > > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > Den 11.03.2019 20.23, skrev Daniel Vetter: [……] > > > > > > > > class_for_each_device

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Ahmed S. Darwish
[[ Adding Sebastian, who is quite experienced in intricate locking situations due to daily PREEMPT_RT work.. ]] On Wed, Mar 13, 2019 at 09:37:10AM +0100, Daniel Vetter wrote: > On Wed, Mar 13, 2019 at 08:49:17AM +0100, John Ogness wrote: > > On 2019-03-12, Ahmed S. Darwish wrote: > > > On

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Koenig, Christian
Am 13.03.19 um 18:33 schrieb Michel Dänzer: > [SNIP] >>> Copy how? Using a GPU engine? >> CPU maybe? Though I suppose that won't work if the buffer isn't CPU >> accesible :/ > Well we do have a debug path for accessing invisible memory with the > CPU. > > E.g. three

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Kazlauskas, Nicholas
On 3/13/19 1:33 PM, Michel Dänzer wrote: > On 2019-03-13 5:16 p.m., Kazlauskas, Nicholas wrote: >> On 3/13/19 11:54 AM, Christian König wrote: >>> Am 13.03.19 um 16:38 schrieb Michel Dänzer: On 2019-03-13 2:37 p.m., Christian König wrote: > Am 13.03.19 um 14:31 schrieb Ville Syrjälä:

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Michel Dänzer
On 2019-03-13 5:16 p.m., Kazlauskas, Nicholas wrote: > On 3/13/19 11:54 AM, Christian König wrote: >> Am 13.03.19 um 16:38 schrieb Michel Dänzer: >>> On 2019-03-13 2:37 p.m., Christian König wrote: Am 13.03.19 um 14:31 schrieb Ville Syrjälä: > On Wed, Mar 13, 2019 at 10:35:08AM +0100,

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Koenig, Christian
Am 13.03.19 um 17:16 schrieb Kazlauskas, Nicholas: > On 3/13/19 11:54 AM, Christian König wrote: >> Am 13.03.19 um 16:38 schrieb Michel Dänzer: >>> On 2019-03-13 2:37 p.m., Christian König wrote: Am 13.03.19 um 14:31 schrieb Ville Syrjälä: > On Wed, Mar 13, 2019 at 10:35:08AM +0100,

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Kazlauskas, Nicholas
On 3/13/19 11:54 AM, Christian König wrote: > Am 13.03.19 um 16:38 schrieb Michel Dänzer: >> On 2019-03-13 2:37 p.m., Christian König wrote: >>> Am 13.03.19 um 14:31 schrieb Ville Syrjälä: On Wed, Mar 13, 2019 at 10:35:08AM +0100, Michel Dänzer wrote: > On 2019-03-12 6:15 p.m., Noralf

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Christian König
Am 13.03.19 um 16:38 schrieb Michel Dänzer: On 2019-03-13 2:37 p.m., Christian König wrote: Am 13.03.19 um 14:31 schrieb Ville Syrjälä: On Wed, Mar 13, 2019 at 10:35:08AM +0100, Michel Dänzer wrote: On 2019-03-12 6:15 p.m., Noralf Trønnes wrote: Den 12.03.2019 17.17, skrev Ville Syrjälä: On

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Michel Dänzer
On 2019-03-13 2:37 p.m., Christian König wrote: > Am 13.03.19 um 14:31 schrieb Ville Syrjälä: >> On Wed, Mar 13, 2019 at 10:35:08AM +0100, Michel Dänzer wrote: >>> On 2019-03-12 6:15 p.m., Noralf Trønnes wrote: Den 12.03.2019 17.17, skrev Ville Syrjälä: > On Tue, Mar 12, 2019 at

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Christian König
Am 13.03.19 um 14:31 schrieb Ville Syrjälä: On Wed, Mar 13, 2019 at 10:35:08AM +0100, Michel Dänzer wrote: On 2019-03-12 6:15 p.m., Noralf Trønnes wrote: Den 12.03.2019 17.17, skrev Ville Syrjälä: On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: On 2019-03-11 6:42 p.m., Noralf

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Ville Syrjälä
On Wed, Mar 13, 2019 at 10:35:08AM +0100, Michel Dänzer wrote: > On 2019-03-12 6:15 p.m., Noralf Trønnes wrote: > > > > > > Den 12.03.2019 17.17, skrev Ville Syrjälä: > >> On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: > >>> On 2019-03-11 6:42 p.m., Noralf Trønnes wrote: >

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Noralf Trønnes
Den 12.03.2019 23.13, skrev Ahmed S. Darwish: > Hi, > > [[ CCing John for the trylock parts ]] > > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: >> >> >> Den 11.03.2019 20.23, skrev Daniel Vetter: >>> On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: This

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Michel Dänzer
On 2019-03-12 6:15 p.m., Noralf Trønnes wrote: > > > Den 12.03.2019 17.17, skrev Ville Syrjälä: >> On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: >>> On 2019-03-11 6:42 p.m., Noralf Trønnes wrote: This adds support for outputting kernel messages on panic(). A kernel

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread John Ogness
On 2019-03-12, Ahmed S. Darwish wrote: + +static void drm_panic_kmsg_dump(struct kmsg_dumper *dumper, + enum kmsg_dump_reason reason) +{ + class_for_each_device(drm_class, NULL, dumper, drm_panic_dev_iter); >>> >>> class_for_each_device uses

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Ahmed S. Darwish
Hi, [[ CCing John for the trylock parts ]] On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > Den 11.03.2019 20.23, skrev Daniel Vetter: > > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: > >> This adds support for outputting kernel messages on panic(). > >> A

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Daniel Vetter
On Tue, Mar 12, 2019 at 08:02:56PM +0200, Ville Syrjälä wrote: > On Tue, Mar 12, 2019 at 06:37:57PM +0100, Noralf Trønnes wrote: > > > > > > Den 12.03.2019 18.25, skrev Ville Syrjälä: > > > On Tue, Mar 12, 2019 at 06:15:24PM +0100, Noralf Trønnes wrote: > > >> > > >> > > >> Den 12.03.2019 17.17,

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Daniel Vetter
On Wed, Mar 13, 2019 at 08:49:17AM +0100, John Ogness wrote: > On 2019-03-12, Ahmed S. Darwish wrote: > + > +static void drm_panic_kmsg_dump(struct kmsg_dumper *dumper, > +enum kmsg_dump_reason reason) > +{ > +

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Daniel Vetter
On Tue, Mar 12, 2019 at 11:13:03PM +0100, Ahmed S. Darwish wrote: > Hi, > > [[ CCing John for the trylock parts ]] > > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > > > > Den 11.03.2019 20.23, skrev Daniel Vetter: > > > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Christian König
Am 12.03.19 um 19:02 schrieb Ville Syrjälä: On Tue, Mar 12, 2019 at 06:37:57PM +0100, Noralf Trønnes wrote: Den 12.03.2019 18.25, skrev Ville Syrjälä: On Tue, Mar 12, 2019 at 06:15:24PM +0100, Noralf Trønnes wrote: Den 12.03.2019 17.17, skrev Ville Syrjälä: On Tue, Mar 12, 2019 at

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Ahmed S. Darwish
Hi, [[ CCing John for the trylock parts ]] On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > Den 11.03.2019 20.23, skrev Daniel Vetter: > > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: > >> This adds support for outputting kernel messages on panic(). > >> A

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Ahmed S. Darwish
Hi, On Tue, Mar 12, 2019 at 11:58:10AM +0100, Daniel Vetter wrote: > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > > > > Den 11.03.2019 20.23, skrev Daniel Vetter: > > > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: [...] > > >> +} > > >> + > > >> +static

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Ville Syrjälä
On Tue, Mar 12, 2019 at 06:37:57PM +0100, Noralf Trønnes wrote: > > > Den 12.03.2019 18.25, skrev Ville Syrjälä: > > On Tue, Mar 12, 2019 at 06:15:24PM +0100, Noralf Trønnes wrote: > >> > >> > >> Den 12.03.2019 17.17, skrev Ville Syrjälä: > >>> On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Noralf Trønnes
Den 12.03.2019 18.37, skrev Noralf Trønnes: > > > Den 12.03.2019 18.25, skrev Ville Syrjälä: >> On Tue, Mar 12, 2019 at 06:15:24PM +0100, Noralf Trønnes wrote: >>> >>> >>> Den 12.03.2019 17.17, skrev Ville Syrjälä: On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: > On

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Noralf Trønnes
Den 12.03.2019 18.25, skrev Ville Syrjälä: > On Tue, Mar 12, 2019 at 06:15:24PM +0100, Noralf Trønnes wrote: >> >> >> Den 12.03.2019 17.17, skrev Ville Syrjälä: >>> On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: On 2019-03-11 6:42 p.m., Noralf Trønnes wrote: > This adds

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Ville Syrjälä
On Tue, Mar 12, 2019 at 06:15:24PM +0100, Noralf Trønnes wrote: > > > Den 12.03.2019 17.17, skrev Ville Syrjälä: > > On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: > >> On 2019-03-11 6:42 p.m., Noralf Trønnes wrote: > >>> This adds support for outputting kernel messages on

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Noralf Trønnes
Den 12.03.2019 17.17, skrev Ville Syrjälä: > On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: >> On 2019-03-11 6:42 p.m., Noralf Trønnes wrote: >>> This adds support for outputting kernel messages on panic(). >>> A kernel message dumper is used to dump the log. The dumper iterates

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Ville Syrjälä
On Tue, Mar 12, 2019 at 11:47:04AM +0100, Michel Dänzer wrote: > On 2019-03-11 6:42 p.m., Noralf Trønnes wrote: > > This adds support for outputting kernel messages on panic(). > > A kernel message dumper is used to dump the log. The dumper iterates > > over each DRM device and it's crtc's to find

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Noralf Trønnes
Den 12.03.2019 11.58, skrev Daniel Vetter: > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: >> >> >> Den 11.03.2019 20.23, skrev Daniel Vetter: >>> On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: This adds support for outputting kernel messages on panic().

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Daniel Vetter
On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > Den 11.03.2019 20.23, skrev Daniel Vetter: > > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: > >> This adds support for outputting kernel messages on panic(). > >> A kernel message dumper is used to dump the

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Michel Dänzer
On 2019-03-11 6:42 p.m., Noralf Trønnes wrote: > This adds support for outputting kernel messages on panic(). > A kernel message dumper is used to dump the log. The dumper iterates > over each DRM device and it's crtc's to find suitable framebuffers. > > All the other dumpers are run before this

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Daniel Vetter
On Tue, Mar 12, 2019 at 10:53:20AM +0100, Daniel Vetter wrote: > On Mon, Mar 11, 2019 at 11:40:36PM +0100, Noralf Trønnes wrote: > > > > > > Den 11.03.2019 20.29, skrev Daniel Vetter: > > > On Mon, Mar 11, 2019 at 08:23:38PM +0100, Daniel Vetter wrote: > > >> On Mon, Mar 11, 2019 at 06:42:16PM

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Daniel Vetter
On Mon, Mar 11, 2019 at 11:40:36PM +0100, Noralf Trønnes wrote: > > > Den 11.03.2019 20.29, skrev Daniel Vetter: > > On Mon, Mar 11, 2019 at 08:23:38PM +0100, Daniel Vetter wrote: > >> On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: > >>> This adds support for outputting kernel

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Noralf Trønnes
Den 11.03.2019 20.29, skrev Daniel Vetter: > On Mon, Mar 11, 2019 at 08:23:38PM +0100, Daniel Vetter wrote: >> On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: >>> This adds support for outputting kernel messages on panic(). >>> A kernel message dumper is used to dump the log. The

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Noralf Trønnes
Den 11.03.2019 20.23, skrev Daniel Vetter: > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: >> This adds support for outputting kernel messages on panic(). >> A kernel message dumper is used to dump the log. The dumper iterates >> over each DRM device and it's crtc's to find

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Sam Ravnborg
Hi Noralf. Nice! > +++ b/drivers/gpu/drm/drm_panic.c > @@ -0,0 +1,363 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright 2018 Noralf Trønnes > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include >

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Daniel Vetter
On Mon, Mar 11, 2019 at 08:23:38PM +0100, Daniel Vetter wrote: > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: > > This adds support for outputting kernel messages on panic(). > > A kernel message dumper is used to dump the log. The dumper iterates > > over each DRM device and

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Daniel Vetter
On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: > This adds support for outputting kernel messages on panic(). > A kernel message dumper is used to dump the log. The dumper iterates > over each DRM device and it's crtc's to find suitable framebuffers. > > All the other dumpers are

[PATCH v2 1/3] drm: Add support for panic message output

2019-03-11 Thread Noralf Trønnes
This adds support for outputting kernel messages on panic(). A kernel message dumper is used to dump the log. The dumper iterates over each DRM device and it's crtc's to find suitable framebuffers. All the other dumpers are run before this one except mtdoops. Only atomic drivers are supported.