Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-03 Thread Daniel Vetter
On Tue, Apr 2, 2019 at 6:47 PM Sean Paul wrote: > On Tue, Apr 02, 2019 at 06:05:48PM +0200, Daniel Vetter wrote: > > On Tue, Apr 2, 2019 at 3:24 PM Sean Paul wrote: > > > > > > On Tue, Apr 02, 2019 at 09:49:00AM +0200, Daniel Vetter wrote: > > > > On Mon, Apr 01, 2019 at 09:49:30AM -0400, Sean

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Sean Paul
On Tue, Apr 02, 2019 at 06:05:48PM +0200, Daniel Vetter wrote: > On Tue, Apr 2, 2019 at 3:24 PM Sean Paul wrote: > > > > On Tue, Apr 02, 2019 at 09:49:00AM +0200, Daniel Vetter wrote: > > > On Mon, Apr 01, 2019 at 09:49:30AM -0400, Sean Paul wrote: > > > > On Fri, Mar 29, 2019 at 08:21:31PM

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Daniel Vetter
On Tue, Apr 2, 2019 at 3:24 PM Sean Paul wrote: > > On Tue, Apr 02, 2019 at 09:49:00AM +0200, Daniel Vetter wrote: > > On Mon, Apr 01, 2019 at 09:49:30AM -0400, Sean Paul wrote: > > > On Fri, Mar 29, 2019 at 08:21:31PM +0100, Daniel Vetter wrote: > > > > On Fri, Mar 29, 2019 at 7:10 PM Sean Paul

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Ville Syrjälä
On Tue, Apr 02, 2019 at 09:49:00AM +0200, Daniel Vetter wrote: > On Mon, Apr 01, 2019 at 09:49:30AM -0400, Sean Paul wrote: > > On Fri, Mar 29, 2019 at 08:21:31PM +0100, Daniel Vetter wrote: > > > On Fri, Mar 29, 2019 at 7:10 PM Sean Paul wrote: > > > > > > > > On Fri, Mar 29, 2019 at 04:36:32PM

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Sean Paul
On Tue, Apr 02, 2019 at 09:49:00AM +0200, Daniel Vetter wrote: > On Mon, Apr 01, 2019 at 09:49:30AM -0400, Sean Paul wrote: > > On Fri, Mar 29, 2019 at 08:21:31PM +0100, Daniel Vetter wrote: > > > On Fri, Mar 29, 2019 at 7:10 PM Sean Paul wrote: > > > > > > > > On Fri, Mar 29, 2019 at 04:36:32PM

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 04:44:54PM -0400, Sean Paul wrote: > From: Sean Paul > > This patch adds a new drm helper library to help drivers implement > self refresh. Drivers choosing to use it will register crtcs and > will receive callbacks when it's time to enter or exit self refresh > mode. >

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Daniel Vetter
On Tue, Apr 2, 2019 at 11:45 AM Neil Armstrong wrote: > > On 02/04/2019 11:08, Daniel Vetter wrote: > > On Tue, Apr 02, 2019 at 10:55:24AM +0200, Neil Armstrong wrote: > >> Hi Sean, > >> > >> On 26/03/2019 21:44, Sean Paul wrote: > >>> From: Sean Paul > >>> > >>> This patch adds a new drm helper

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Neil Armstrong
On 02/04/2019 11:08, Daniel Vetter wrote: > On Tue, Apr 02, 2019 at 10:55:24AM +0200, Neil Armstrong wrote: >> Hi Sean, >> >> On 26/03/2019 21:44, Sean Paul wrote: >>> From: Sean Paul >>> >>> This patch adds a new drm helper library to help drivers implement >>> self refresh. Drivers choosing to

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Daniel Vetter
On Tue, Apr 02, 2019 at 10:55:24AM +0200, Neil Armstrong wrote: > Hi Sean, > > On 26/03/2019 21:44, Sean Paul wrote: > > From: Sean Paul > > > > This patch adds a new drm helper library to help drivers implement > > self refresh. Drivers choosing to use it will register crtcs and > > will

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Neil Armstrong
Hi Sean, On 26/03/2019 21:44, Sean Paul wrote: > From: Sean Paul > > This patch adds a new drm helper library to help drivers implement > self refresh. Drivers choosing to use it will register crtcs and > will receive callbacks when it's time to enter or exit self refresh > mode. > > In its

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Daniel Vetter
On Mon, Apr 01, 2019 at 09:49:30AM -0400, Sean Paul wrote: > On Fri, Mar 29, 2019 at 08:21:31PM +0100, Daniel Vetter wrote: > > On Fri, Mar 29, 2019 at 7:10 PM Sean Paul wrote: > > > > > > On Fri, Mar 29, 2019 at 04:36:32PM +0100, Daniel Vetter wrote: > > > > On Fri, Mar 29, 2019 at 09:16:59AM

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-01 Thread Sean Paul
On Fri, Mar 29, 2019 at 08:21:31PM +0100, Daniel Vetter wrote: > On Fri, Mar 29, 2019 at 7:10 PM Sean Paul wrote: > > > > On Fri, Mar 29, 2019 at 04:36:32PM +0100, Daniel Vetter wrote: > > > On Fri, Mar 29, 2019 at 09:16:59AM -0400, Sean Paul wrote: > > > > On Fri, Mar 29, 2019 at 09:21:10AM

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-29 Thread Daniel Vetter
On Fri, Mar 29, 2019 at 7:10 PM Sean Paul wrote: > > On Fri, Mar 29, 2019 at 04:36:32PM +0100, Daniel Vetter wrote: > > On Fri, Mar 29, 2019 at 09:16:59AM -0400, Sean Paul wrote: > > > On Fri, Mar 29, 2019 at 09:21:10AM +0100, Daniel Vetter wrote: > > > > On Thu, Mar 28, 2019 at 05:03:03PM -0400,

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-29 Thread Sean Paul
On Fri, Mar 29, 2019 at 04:36:32PM +0100, Daniel Vetter wrote: > On Fri, Mar 29, 2019 at 09:16:59AM -0400, Sean Paul wrote: > > On Fri, Mar 29, 2019 at 09:21:10AM +0100, Daniel Vetter wrote: > > > On Thu, Mar 28, 2019 at 05:03:03PM -0400, Sean Paul wrote: > > > > On Wed, Mar 27, 2019 at 07:15:00PM

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-29 Thread Daniel Vetter
On Fri, Mar 29, 2019 at 09:16:59AM -0400, Sean Paul wrote: > On Fri, Mar 29, 2019 at 09:21:10AM +0100, Daniel Vetter wrote: > > On Thu, Mar 28, 2019 at 05:03:03PM -0400, Sean Paul wrote: > > > On Wed, Mar 27, 2019 at 07:15:00PM +0100, Daniel Vetter wrote: > > > > On Tue, Mar 26, 2019 at 04:44:54PM

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-29 Thread Sean Paul
On Fri, Mar 29, 2019 at 09:21:10AM +0100, Daniel Vetter wrote: > On Thu, Mar 28, 2019 at 05:03:03PM -0400, Sean Paul wrote: > > On Wed, Mar 27, 2019 at 07:15:00PM +0100, Daniel Vetter wrote: > > > On Tue, Mar 26, 2019 at 04:44:54PM -0400, Sean Paul wrote: > > > > From: Sean Paul > > > > > > > >

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-29 Thread Daniel Vetter
On Thu, Mar 28, 2019 at 05:03:03PM -0400, Sean Paul wrote: > On Wed, Mar 27, 2019 at 07:15:00PM +0100, Daniel Vetter wrote: > > On Tue, Mar 26, 2019 at 04:44:54PM -0400, Sean Paul wrote: > > > From: Sean Paul > > > > > > This patch adds a new drm helper library to help drivers implement > > >

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-28 Thread Sean Paul
On Wed, Mar 27, 2019 at 07:15:00PM +0100, Daniel Vetter wrote: > On Tue, Mar 26, 2019 at 04:44:54PM -0400, Sean Paul wrote: > > From: Sean Paul > > > > This patch adds a new drm helper library to help drivers implement > > self refresh. Drivers choosing to use it will register crtcs and > > will

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-28 Thread Dan Carpenter
Hi Sean, url: https://github.com/0day-ci/linux/commits/Sean-Paul/drm-Add-helpers-to-kick-off-self-refresh-mode-in-drivers/20190327-194853 smatch warnings: drivers/gpu/drm/drm_self_refresh_helper.c:105 drm_self_refresh_helper_entry_work() error: uninitialized symbol 'ret'. #

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-27 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 04:44:54PM -0400, Sean Paul wrote: > From: Sean Paul > > This patch adds a new drm helper library to help drivers implement > self refresh. Drivers choosing to use it will register crtcs and > will receive callbacks when it's time to enter or exit self refresh > mode. >

[PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-26 Thread Sean Paul
From: Sean Paul This patch adds a new drm helper library to help drivers implement self refresh. Drivers choosing to use it will register crtcs and will receive callbacks when it's time to enter or exit self refresh mode. In its current form, it has a timer which will trigger after a