Re: [PATCH v2 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-09-18 Thread Philipp Stanner
On Sat, 2023-09-16 at 17:32 +0300, Dan Carpenter wrote: > On Fri, Sep 08, 2023 at 09:59:40PM +0200, Philipp Stanner wrote: > > +static inline void *memdup_array_user(const void __user *src, > > size_t n, size_t size) > > +{ > > +   size_t nbytes; > > + > > +   if (unlikely(check_mul_overflo

Re: [PATCH v2 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-09-17 Thread Andy Shevchenko
On Sat, Sep 16, 2023 at 05:32:42PM +0300, Dan Carpenter wrote: > On Fri, Sep 08, 2023 at 09:59:40PM +0200, Philipp Stanner wrote: ... > > +static inline void *memdup_array_user(const void __user *src, size_t n, > > size_t size) > > +{ > > + size_t nbytes; > > + > > + if (unlikely(check_mul_o

Re: [PATCH v2 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-09-16 Thread Dan Carpenter
On Fri, Sep 08, 2023 at 09:59:40PM +0200, Philipp Stanner wrote: > +static inline void *memdup_array_user(const void __user *src, size_t n, > size_t size) > +{ > + size_t nbytes; > + > + if (unlikely(check_mul_overflow(n, size, &nbytes))) > + return ERR_PTR(-EOVERFLOW); No nee

Re: [PATCH v2 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-09-10 Thread Andy Shevchenko
On Fri, Sep 8, 2023 at 11:02 PM Philipp Stanner wrote: > > Currently, user array duplications are sometimes done without an > overflow check. Sometimes the checks are done manually; sometimes the > array size is calculated with array_size() and sometimes by calculating > n * size directly in code.

[PATCH v2 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-09-08 Thread Philipp Stanner
Currently, user array duplications are sometimes done without an overflow check. Sometimes the checks are done manually; sometimes the array size is calculated with array_size() and sometimes by calculating n * size directly in code. Introduce wrappers for arrays for memdup_user() and vmemdup_user