Re: [PATCH v2 12/17] drm/vc4: crtc: Introduce a lower-level crtc init helper

2022-11-28 Thread MaĆ­ra Canal
On 11/28/22 11:53, Maxime Ripard wrote: > The current vc4_crtc_init() helper assumes that we will be using > hardware planes and calls vc4_plane_init(). > > While it's a reasonable assumption, we'll want to mock the plane and > thus provide our own. Let's create a helper that will take the plane a

[PATCH v2 12/17] drm/vc4: crtc: Introduce a lower-level crtc init helper

2022-11-28 Thread Maxime Ripard
The current vc4_crtc_init() helper assumes that we will be using hardware planes and calls vc4_plane_init(). While it's a reasonable assumption, we'll want to mock the plane and thus provide our own. Let's create a helper that will take the plane as an argument. Reviewed-by: Javier Martinez Canil