Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-22 Thread Matt Roper
On Thu, Feb 22, 2024 at 11:03:27PM +0100, Andi Shyti wrote: > Hi Matt, > > first of all thanks a lot for the observations you are raising. > > On Wed, Feb 21, 2024 at 12:51:04PM -0800, Matt Roper wrote: > > On Wed, Feb 21, 2024 at 01:12:18AM +0100, Andi Shyti wrote: > > > On Tue, Feb 20, 2024 at

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-22 Thread Andi Shyti
Hi Matt, first of all thanks a lot for the observations you are raising. On Wed, Feb 21, 2024 at 12:51:04PM -0800, Matt Roper wrote: > On Wed, Feb 21, 2024 at 01:12:18AM +0100, Andi Shyti wrote: > > On Tue, Feb 20, 2024 at 03:39:18PM -0800, Matt Roper wrote: > > > On Tue, Feb 20, 2024 at 03:35:26

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-21 Thread Matt Roper
On Wed, Feb 21, 2024 at 01:12:18AM +0100, Andi Shyti wrote: > Hi Matt, > > thanks a lot for looking into this. > > On Tue, Feb 20, 2024 at 03:39:18PM -0800, Matt Roper wrote: > > On Tue, Feb 20, 2024 at 03:35:26PM +0100, Andi Shyti wrote: > > [...] > > > > diff --git a/drivers/gpu/drm/i915/gt/i

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-21 Thread Tvrtko Ursulin
On 21/02/2024 12:08, Tvrtko Ursulin wrote: On 21/02/2024 11:19, Andi Shyti wrote: Hi Tvrtko, On Wed, Feb 21, 2024 at 08:19:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Andi Shyti wrote: On Tue, Feb 20, 2024 at 02:48:31PM +, Tvrtko Ursulin wrote: On 20/02/2024 14:35, Andi Sh

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-21 Thread Tvrtko Ursulin
On 21/02/2024 11:19, Andi Shyti wrote: Hi Tvrtko, On Wed, Feb 21, 2024 at 08:19:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Andi Shyti wrote: On Tue, Feb 20, 2024 at 02:48:31PM +, Tvrtko Ursulin wrote: On 20/02/2024 14:35, Andi Shyti wrote: Enable only one CCS engine by defa

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-21 Thread Andi Shyti
Hi Tvrtko, On Wed, Feb 21, 2024 at 08:19:34AM +, Tvrtko Ursulin wrote: > On 21/02/2024 00:14, Andi Shyti wrote: > > On Tue, Feb 20, 2024 at 02:48:31PM +, Tvrtko Ursulin wrote: > > > On 20/02/2024 14:35, Andi Shyti wrote: > > > > Enable only one CCS engine by default with all the compute si

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-21 Thread Tvrtko Ursulin
On 21/02/2024 00:14, Andi Shyti wrote: Hi Tvrtko, On Tue, Feb 20, 2024 at 02:48:31PM +, Tvrtko Ursulin wrote: On 20/02/2024 14:35, Andi Shyti wrote: Enable only one CCS engine by default with all the compute sices slices Thanks! diff --git a/drivers/gpu/drm/i915/gt/intel_engine_use

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-20 Thread Andi Shyti
Hi Tvrtko, On Tue, Feb 20, 2024 at 02:48:31PM +, Tvrtko Ursulin wrote: > On 20/02/2024 14:35, Andi Shyti wrote: > > Enable only one CCS engine by default with all the compute sices > > slices Thanks! > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_user.c > > b/drivers/gpu/drm/i915/gt

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-20 Thread Andi Shyti
Hi Matt, thanks a lot for looking into this. On Tue, Feb 20, 2024 at 03:39:18PM -0800, Matt Roper wrote: > On Tue, Feb 20, 2024 at 03:35:26PM +0100, Andi Shyti wrote: [...] > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_user.c > > b/drivers/gpu/drm/i915/gt/intel_engine_user.c > > index

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-20 Thread Matt Roper
On Tue, Feb 20, 2024 at 03:35:26PM +0100, Andi Shyti wrote: > Enable only one CCS engine by default with all the compute sices > allocated to it. > > While generating the list of UABI engines to be exposed to the > user, exclude any additional CCS engines beyond the first > instance. > > This cha

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-20 Thread Tvrtko Ursulin
On 20/02/2024 14:35, Andi Shyti wrote: Enable only one CCS engine by default with all the compute sices slices allocated to it. While generating the list of UABI engines to be exposed to the user, exclude any additional CCS engines beyond the first instance. This change can be tested with

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-20 Thread Andi Shyti
Hi, [...] > diff --git a/drivers/gpu/drm/i915/i915_query.c > b/drivers/gpu/drm/i915/i915_query.c > index 3baa2f54a86e..d5a5143971f5 100644 > --- a/drivers/gpu/drm/i915/i915_query.c > +++ b/drivers/gpu/drm/i915/i915_query.c > @@ -124,6 +124,7 @@ static int query_geometry_subslices(struct > drm_i

[PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-20 Thread Andi Shyti
Enable only one CCS engine by default with all the compute sices allocated to it. While generating the list of UABI engines to be exposed to the user, exclude any additional CCS engines beyond the first instance. This change can be tested with igt i915_query. Fixes: d2eae8e98d59 ("drm/i915/dg2: