Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-24 Thread Steven Price
On 24/06/2021 10:56, Boris Brezillon wrote: > On Thu, 24 Jun 2021 10:23:51 +0100 > Steven Price wrote: > >>> static void panfrost_job_handle_irq(struct panfrost_device *pfdev, u32 >>> status) >>> { >>> - int j; >>> + struct panfrost_job *done[NUM_JOB_SLOTS][2] = {}; >>> + struct panfrost

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-24 Thread Boris Brezillon
On Thu, 24 Jun 2021 10:23:51 +0100 Steven Price wrote: > > static void panfrost_job_handle_irq(struct panfrost_device *pfdev, u32 > > status) > > { > > - int j; > > + struct panfrost_job *done[NUM_JOB_SLOTS][2] = {}; > > + struct panfrost_job *failed[NUM_JOB_SLOTS] = {}; > > + u32 js_s

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-24 Thread Steven Price
Hi Boris, I tested it out and I see a performance improvement with Mesa which is nice! However a few concerns noted below. On 21/06/2021 15:02, Boris Brezillon wrote: > From: Steven Price > > The hardware has a set of '_NEXT' registers that can hold a second job > while the first is executing.

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-21 Thread Boris Brezillon
On Mon, 21 Jun 2021 17:08:21 +0100 Steven Price wrote: > On 21/06/2021 15:02, Boris Brezillon wrote: > > From: Steven Price > > > > The hardware has a set of '_NEXT' registers that can hold a second job > > while the first is executing. Make use of these registers to enqueue a > > second job pe

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-21 Thread Boris Brezillon
On Mon, 21 Jun 2021 14:20:31 -0400 Alyssa Rosenzweig wrote: > > Also that feature was only introduced in t76x. So relying on that would > > sadly kill off support for t60x, t62x and t72x (albeit I'm not sure how > > 'supported' these are with Mesa anyway). > > t60x and t62x are not supported,

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-21 Thread Alyssa Rosenzweig
> Also that feature was only introduced in t76x. So relying on that would > sadly kill off support for t60x, t62x and t72x (albeit I'm not sure how > 'supported' these are with Mesa anyway). t60x and t62x are not supported, but t720 very much is (albeit GLES2 only, versus t760+ getting GLES3.1 and

Re: [PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-21 Thread Steven Price
On 21/06/2021 15:02, Boris Brezillon wrote: > From: Steven Price > > The hardware has a set of '_NEXT' registers that can hold a second job > while the first is executing. Make use of these registers to enqueue a > second job per slot. > > v2: > * Make sure non-faulty jobs get properly paused/re

[PATCH v2 2/2] drm/panfrost: Queue jobs on the hardware

2021-06-21 Thread Boris Brezillon
From: Steven Price The hardware has a set of '_NEXT' registers that can hold a second job while the first is executing. Make use of these registers to enqueue a second job per slot. v2: * Make sure non-faulty jobs get properly paused/resumed on GPU reset Signed-off-by: Steven Price Signed-off-