Re: [kbuild-all] Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-15 Thread Dan Carpenter
On Wed, Dec 16, 2020 at 09:06:50AM +0800, Philip Li wrote: > On Mon, Dec 14, 2020 at 09:49:17PM +0300, Dan Carpenter wrote: > > On Sat, Dec 12, 2020 at 04:54:45PM +0800, Philip Li wrote: > > > On Fri, Dec 11, 2020 at 04:42:00PM +0200, Ville Syrjälä wrote: > > > > On Fri, Dec 11, 2020 at 01:24:49PM

Re: [kbuild-all] Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-15 Thread Philip Li
On Mon, Dec 14, 2020 at 09:49:17PM +0300, Dan Carpenter wrote: > On Sat, Dec 12, 2020 at 04:54:45PM +0800, Philip Li wrote: > > On Fri, Dec 11, 2020 at 04:42:00PM +0200, Ville Syrjälä wrote: > > > On Fri, Dec 11, 2020 at 01:24:49PM +0200, Tomi Valkeinen wrote: > > > > On 10/12/2020 20:06, kernel

Re: [kbuild-all] Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-14 Thread Dan Carpenter
On Sat, Dec 12, 2020 at 04:54:45PM +0800, Philip Li wrote: > On Fri, Dec 11, 2020 at 04:42:00PM +0200, Ville Syrjälä wrote: > > On Fri, Dec 11, 2020 at 01:24:49PM +0200, Tomi Valkeinen wrote: > > > On 10/12/2020 20:06, kernel test robot wrote: > > > > Hi Tomi, > > > > > > > > I love your patch!

Re: [kbuild-all] Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-12 Thread Philip Li
On Fri, Dec 11, 2020 at 04:42:00PM +0200, Ville Syrjälä wrote: > On Fri, Dec 11, 2020 at 01:24:49PM +0200, Tomi Valkeinen wrote: > > On 10/12/2020 20:06, kernel test robot wrote: > > > Hi Tomi, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test WARNING on

Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-11 Thread Tomi Valkeinen
On 10/12/2020 20:06, kernel test robot wrote: > Hi Tomi, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on drm-intel/for-linux-next] > [also build test WARNING on linus/master v5.10-rc7] > [cannot apply to drm-tip/drm-tip anholt/for-next next-20201210] > [If

Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-11 Thread Ville Syrjälä
On Fri, Dec 11, 2020 at 01:24:49PM +0200, Tomi Valkeinen wrote: > On 10/12/2020 20:06, kernel test robot wrote: > > Hi Tomi, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on drm-intel/for-linux-next] > > [also build test WARNING on linus/master

Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-10 Thread kernel test robot
Hi Tomi, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on linus/master v5.10-rc7] [cannot apply to drm-tip/drm-tip anholt/for-next next-20201210] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-08 Thread kernel test robot
Hi Tomi, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on linus/master v5.10-rc7] [cannot apply to drm-tip/drm-tip anholt/for-next next-20201208] [If your patch is applied to the wrong git tree, kindly drop us a

[PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-08 Thread Tomi Valkeinen
To support legacy gamma ioctls the drivers need to set drm_crtc_funcs.gamma_set either to a custom implementation or to drm_atomic_helper_legacy_gamma_set. Most of the atomic drivers do the latter. We can simplify this by making the core handle it automatically. Add two functions:

Re: [PATCH v2 2/2] drm: automatic legacy gamma support

2020-12-08 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Dec 08, 2020 at 03:57:59PM +0200, Tomi Valkeinen wrote: > To support legacy gamma ioctls the drivers need to set > drm_crtc_funcs.gamma_set either to a custom implementation or to > drm_atomic_helper_legacy_gamma_set. Most of the atomic drivers do the >