Re: [PATCH v2 2/3] drm/msm: Fix IS_ERR() vs NULL check in a5xx_submit_in_rb()

On Thu, 13 Jul 2023 at 22:08, Akhil P Oommen wrote: > > On Thu, Jul 13, 2023 at 10:05:55AM +0800, Gaosheng Cui wrote: > > > > The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should > > use IS_ERR() to check the return value. > > > > Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to

Re: [PATCH v2 2/3] drm/msm: Fix IS_ERR() vs NULL check in a5xx_submit_in_rb()

On Thu, Jul 13, 2023 at 10:05:55AM +0800, Gaosheng Cui wrote: > > The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should > use IS_ERR() to check the return value. > > Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl") > Signed-off-by: Gaosheng Cui > Reviewed-by: Abhinav

Re: [PATCH v2 2/3] drm/msm: Fix IS_ERR() vs NULL check in a5xx_submit_in_rb()

On 7/12/2023 7:05 PM, Gaosheng Cui wrote: The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl") Signed-off-by: Gaosheng Cui Reviewed-by: Abhinav Kumar --- You dropped

[PATCH v2 2/3] drm/msm: Fix IS_ERR() vs NULL check in a5xx_submit_in_rb()

The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl") Signed-off-by: Gaosheng Cui Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- 1 file changed, 1