[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-18 Thread Mark Zhang
On 01/15/2013 06:50 PM, Lucas Stach wrote: > Am Dienstag, den 15.01.2013, 17:53 +0800 schrieb Mark Zhang: >> On 01/15/2013 12:05 AM, Thierry Reding wrote: >>> Add support for the B and C planes which support RGB and YUV pixel >>> formats and can be used as overlays or hardware cursor. >> >> I think

Re: [PATCH v2 2/5] drm/tegra: Add plane support

2013-01-17 Thread Mark Zhang
On 01/15/2013 06:50 PM, Lucas Stach wrote: > Am Dienstag, den 15.01.2013, 17:53 +0800 schrieb Mark Zhang: >> On 01/15/2013 12:05 AM, Thierry Reding wrote: >>> Add support for the B and C planes which support RGB and YUV pixel >>> formats and can be used as overlays or hardware cursor. >> >> I think

[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Mark Zhang
On 01/15/2013 12:05 AM, Thierry Reding wrote: > Add support for the B and C planes which support RGB and YUV pixel > formats and can be used as overlays or hardware cursor. I think "hardware cursor" has specific meaning for Tegra(e.g: Tegra30 has a 32x32 24bpp or 64x64 2bpp hardware cursor). So yo

[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Ville Syrjälä
On Tue, Jan 15, 2013 at 05:53:03PM +0800, Mark Zhang wrote: > On 01/15/2013 12:05 AM, Thierry Reding wrote: > > Add support for the B and C planes which support RGB and YUV pixel > > formats and can be used as overlays or hardware cursor. > > I think "hardware cursor" has specific meaning for Tegr

[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:35:32PM +0200, Ville Syrj?l? wrote: > On Tue, Jan 15, 2013 at 05:53:03PM +0800, Mark Zhang wrote: > > On 01/15/2013 12:05 AM, Thierry Reding wrote: > > > Add support for the B and C planes which support RGB and YUV pixel > > > formats and can be used as overlays or hardwa

[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Thierry Reding
On Mon, Jan 14, 2013 at 06:03:44PM +0100, Lucas Stach wrote: > Am Montag, den 14.01.2013, 17:05 +0100 schrieb Thierry Reding: [...] > > + value = (WIN_A_ACT_REQ << index) | (WIN_A_UPDATE << index); > > + tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL); > This should be two separate writes to t

[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Lucas Stach
Am Dienstag, den 15.01.2013, 17:53 +0800 schrieb Mark Zhang: > On 01/15/2013 12:05 AM, Thierry Reding wrote: > > Add support for the B and C planes which support RGB and YUV pixel > > formats and can be used as overlays or hardware cursor. > > I think "hardware cursor" has specific meaning for Teg

Re: [PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:35:32PM +0200, Ville Syrjälä wrote: > On Tue, Jan 15, 2013 at 05:53:03PM +0800, Mark Zhang wrote: > > On 01/15/2013 12:05 AM, Thierry Reding wrote: > > > Add support for the B and C planes which support RGB and YUV pixel > > > formats and can be used as overlays or hardwa

Re: [PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Ville Syrjälä
On Tue, Jan 15, 2013 at 05:53:03PM +0800, Mark Zhang wrote: > On 01/15/2013 12:05 AM, Thierry Reding wrote: > > Add support for the B and C planes which support RGB and YUV pixel > > formats and can be used as overlays or hardware cursor. > > I think "hardware cursor" has specific meaning for Tegr

Re: [PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Thierry Reding
On Mon, Jan 14, 2013 at 06:03:44PM +0100, Lucas Stach wrote: > Am Montag, den 14.01.2013, 17:05 +0100 schrieb Thierry Reding: [...] > > + value = (WIN_A_ACT_REQ << index) | (WIN_A_UPDATE << index); > > + tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL); > This should be two separate writes to t

Re: [PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Lucas Stach
Am Dienstag, den 15.01.2013, 17:53 +0800 schrieb Mark Zhang: > On 01/15/2013 12:05 AM, Thierry Reding wrote: > > Add support for the B and C planes which support RGB and YUV pixel > > formats and can be used as overlays or hardware cursor. > > I think "hardware cursor" has specific meaning for Teg

Re: [PATCH v2 2/5] drm/tegra: Add plane support

2013-01-15 Thread Mark Zhang
On 01/15/2013 12:05 AM, Thierry Reding wrote: > Add support for the B and C planes which support RGB and YUV pixel > formats and can be used as overlays or hardware cursor. I think "hardware cursor" has specific meaning for Tegra(e.g: Tegra30 has a 32x32 24bpp or 64x64 2bpp hardware cursor). So yo

[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-14 Thread Lucas Stach
Am Montag, den 14.01.2013, 17:05 +0100 schrieb Thierry Reding: > Add support for the B and C planes which support RGB and YUV pixel > formats and can be used as overlays or hardware cursor. > > Signed-off-by: Thierry Reding > --- [...] > +static int tegra_plane_disable(struct drm_plane *plane) >

[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-14 Thread Thierry Reding
Add support for the B and C planes which support RGB and YUV pixel formats and can be used as overlays or hardware cursor. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 321 +++- drivers/gpu/drm/tegra/dc.h | 2 +- drivers/gpu/drm/tegra

Re: [PATCH v2 2/5] drm/tegra: Add plane support

2013-01-14 Thread Lucas Stach
Am Montag, den 14.01.2013, 17:05 +0100 schrieb Thierry Reding: > Add support for the B and C planes which support RGB and YUV pixel > formats and can be used as overlays or hardware cursor. > > Signed-off-by: Thierry Reding > --- [...] > +static int tegra_plane_disable(struct drm_plane *plane) >

[PATCH v2 2/5] drm/tegra: Add plane support

2013-01-14 Thread Thierry Reding
Add support for the B and C planes which support RGB and YUV pixel formats and can be used as overlays or hardware cursor. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 321 +++- drivers/gpu/drm/tegra/dc.h | 2 +- drivers/gpu/drm/tegra