Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-12 Thread Javier Martinez Canillas
Conor Dooley writes: > On Mon, Jun 12, 2023 at 09:47:12AM +0200, Thomas Zimmermann wrote: >> Am 11.06.23 um 01:18 schrieb Javier Martinez Canillas: > >> > But I will be OK to drop the "solomon,ssd130?fb-i2c" compatible strings >> > from the DRM driver and only match against the new "solomon,ssd13

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-12 Thread Conor Dooley
On Mon, Jun 12, 2023 at 09:47:12AM +0200, Thomas Zimmermann wrote: > Am 11.06.23 um 01:18 schrieb Javier Martinez Canillas: > > But I will be OK to drop the "solomon,ssd130?fb-i2c" compatible strings > > from the DRM driver and only match against the new "solomon,ssd130?-i2c" > > compatible string

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-12 Thread Thomas Zimmermann
Hi Am 11.06.23 um 01:18 schrieb Javier Martinez Canillas: Conor Dooley writes: On Sat, Jun 10, 2023 at 07:51:35PM +0200, Javier Martinez Canillas wrote: Conor Dooley writes: On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: A default resolution in the ssd130x driv

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-10 Thread Javier Martinez Canillas
Conor Dooley writes: > On Sat, Jun 10, 2023 at 07:51:35PM +0200, Javier Martinez Canillas wrote: >> Conor Dooley writes: >> >> > On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: >> >> A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 >> >> anymo

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-10 Thread Conor Dooley
On Sat, Jun 10, 2023 at 07:51:35PM +0200, Javier Martinez Canillas wrote: > Conor Dooley writes: > > > On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: > >> A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 > >> anymore. Instead is set to a width

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-10 Thread Javier Martinez Canillas
Conor Dooley writes: > On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: >> A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 >> anymore. Instead is set to a width and height that's controller dependent. > > Did that change to the driver not break

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-10 Thread Conor Dooley
On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote: > A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 > anymore. Instead is set to a width and height that's controller dependent. Did that change to the driver not break backwards compatibility with e

[PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-09 Thread Javier Martinez Canillas
A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 anymore. Instead is set to a width and height that's controller dependent. The datasheets for the chips describes the following display resolutions: - SH1106: 132 x 64 Dot Matrix OLED/PLED - SSD1305: 132 x 64 Dot Matrix