[PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting

2014-01-12 Thread Jean-Francois Moine
On Sun, 12 Jan 2014 12:31:59 + Russell King - ARM Linux wrote: > > So, in my patch 9, I was writing the REG_TBG_CNTRL_1 after writing > > REG_TBG_CNTRL_0, and you refused it. Here, I write REG_TBG_CNTRL_0 > > after the write of REG_TBG_CNTRL_1 in the HDMI sequence, and you still > > don't agr

[PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting

2014-01-12 Thread Russell King - ARM Linux
On Sun, Jan 12, 2014 at 02:20:00PM +0100, Jean-Francois Moine wrote: > On Sun, 12 Jan 2014 12:31:59 + > Russell King - ARM Linux wrote: > > > > So, in my patch 9, I was writing the REG_TBG_CNTRL_1 after writing > > > REG_TBG_CNTRL_0, and you refused it. Here, I write REG_TBG_CNTRL_0 > > > aft

[PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting

2014-01-12 Thread Jean-Francois Moine
On Sat, 11 Jan 2014 18:36:48 + Russell King - ARM Linux wrote: > On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote: > > According to the comment, the TBG_CNTRL_0 register must be set at the > > end of the mode change sequence. > > So you believe comments without understandi

[PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting

2014-01-12 Thread Russell King - ARM Linux
On Sun, Jan 12, 2014 at 01:23:21PM +0100, Jean-Francois Moine wrote: > On Sat, 11 Jan 2014 18:36:48 + > Russell King - ARM Linux wrote: > > > On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote: > > > According to the comment, the TBG_CNTRL_0 register must be set at the > > >

[PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting

2014-01-11 Thread Russell King - ARM Linux
On Thu, Jan 09, 2014 at 12:06:07PM +0100, Jean-Francois Moine wrote: > According to the comment, the TBG_CNTRL_0 register must be set at the > end of the mode change sequence. So you believe comments without understanding the history, and you move code around due to those. No, this is again wrong

[PATCH v2 20/28] drm/i2c: tda998x: move the TBG_CNTRL_0 register setting

2014-01-09 Thread Jean-Francois Moine
According to the comment, the TBG_CNTRL_0 register must be set at the end of the mode change sequence. Signed-off-by: Jean-Francois Moine --- drivers/gpu/drm/i2c/tda998x_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/g