Re: [PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

On Thu, Jul 13, 2023 at 05:51:34PM +0800, cuigaosheng wrote: > Thanks for taking time to review this patch. > > Maybe we can submit another separate patch to fix ERR_CAST(st), because I'm > not > sure which commit should be used as a fixes-tag. > > Also, Maybe we should fix ERR_CAST(st) in >

Re: [PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

Thanks for taking time to review this patch. Maybe we can submit another separate patch to fix ERR_CAST(st), because I'm not sure which commit should be used as a fixes-tag. Also, Maybe we should fix ERR_CAST(st) in komeda_pipeline_get_state_and_set_crtc() and

Re: [PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

Hello, On Thu, Jul 13, 2023 at 10:05:56AM +0800, Gaosheng Cui wrote: > The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should > use IS_ERR() to check the return value. While reviewing the change I've realised that komeda_pipeline_get_state_and_set_crtc() is also mishandling

[PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +- 1