Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:40, Andi Shyti wrote: > Hi Randy, > > [...] > >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> @@ -105,61 +105,67 @@ struct intel_guc { >> */ > > > struct { } interrupts is missing here. > >> struct { >>

Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Andi Shyti
Hi Randy, [...] > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h > @@ -105,61 +105,67 @@ struct intel_guc { >*/ struct { } interrupts is missing here. > struct { > /** > - * @lock: protects everything in

[PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_guc.h:305: warning: Excess struct member 'lock' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'guc_ids' description in 'intel_guc' intel_guc.h:305: warning: