Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Luca Ceresoli
Hi Greg, Arnd, On Fri, 10 May 2024 12:57:24 +0200 "Arnd Bergmann" wrote: > On Fri, May 10, 2024, at 12:54, Luca Ceresoli wrote: > > On Fri, 10 May 2024 12:24:06 +0200 "Arnd Bergmann" wrote: > >> On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote: > >> > On Fri, May 10, 2024 at

Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Greg Kroah-Hartman
On Fri, May 10, 2024 at 12:54:17PM +0200, Luca Ceresoli wrote: > > > +static int sunh_conn_handle_event(struct sunh_conn *conn, bool plugged) > > > +{ > > > + int err; > > > + > > > + if (plugged == conn->plugged) > > > + return 0; > > > + > > > + dev_info(conn->dev, "%s\n", plugged ?

Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Arnd Bergmann
On Fri, May 10, 2024, at 12:54, Luca Ceresoli wrote: > On Fri, 10 May 2024 12:24:06 +0200 "Arnd Bergmann" wrote: >> On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote: >> > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: >> >> >> >> +config GE_SUNH_CONNECTOR >> >> +

Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Luca Ceresoli
Hello Greg, Arnd, On Fri, 10 May 2024 12:24:06 +0200 "Arnd Bergmann" wrote: > On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote: > > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: > >> > >> +config GE_SUNH_CONNECTOR > >> + tristate "GE SUNH hotplug add-on connector"

Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Luca Ceresoli
Hello Greg, thanks for reviewing. On Fri, 10 May 2024 08:55:29 +0100 Greg Kroah-Hartman wrote: > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: > > Add a driver to support the runtime hot-pluggable add-on connector on the > > GE SUNH device. This connector allows connecting and

Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Arnd Bergmann
On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote: > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: >> >> +config GE_SUNH_CONNECTOR >> +tristate "GE SUNH hotplug add-on connector" >> +depends on OF >> +select OF_OVERLAY >> +select FW_LOADER >> +select

Re: [PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Greg Kroah-Hartman
On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: > Add a driver to support the runtime hot-pluggable add-on connector on the > GE SUNH device. This connector allows connecting and disconnecting an > add-on to/from the main device to augment its features. Connection and >

[PATCH v2 5/5] misc: add ge-addon-connector driver

2024-05-10 Thread Luca Ceresoli
Add a driver to support the runtime hot-pluggable add-on connector on the GE SUNH device. This connector allows connecting and disconnecting an add-on to/from the main device to augment its features. Connection and disconnection can happen at runtime at any moment without notice. Different add-on