Re: [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers

2018-07-02 Thread Boris Brezillon
On Mon, 2 Jul 2018 09:57:30 +0200 Daniel Vetter wrote: > On Mon, Jul 02, 2018 at 09:54:32AM +0200, Daniel Vetter wrote: > > On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote: > > > Now that we have a way to fake VBLANK events when requested by the CRTC > > > hook it up to the

Re: [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers

2018-07-02 Thread Boris Brezillon
On Mon, 2 Jul 2018 09:54:32 +0200 Daniel Vetter wrote: > On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote: > > Now that we have a way to fake VBLANK events when requested by the CRTC > > hook it up to the generic commit_tail() helpers. > > > > Signed-off-by: Boris Brezillon >

Re: [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers

2018-07-02 Thread Daniel Vetter
On Mon, Jul 02, 2018 at 09:54:32AM +0200, Daniel Vetter wrote: > On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote: > > Now that we have a way to fake VBLANK events when requested by the CRTC > > hook it up to the generic commit_tail() helpers. > > > > Signed-off-by: Boris Brezillon

Re: [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers

2018-07-02 Thread Daniel Vetter
On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote: > Now that we have a way to fake VBLANK events when requested by the CRTC > hook it up to the generic commit_tail() helpers. > > Signed-off-by: Boris Brezillon I really don't like this. We've had epic amounts of bugs with atomic

Re: [PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers

2018-06-29 Thread Liviu Dudau
On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote: > Now that we have a way to fake VBLANK events when requested by the CRTC > hook it up to the generic commit_tail() helpers. > > Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau > --- >

[PATCH v2 5/8] drm/atomic: Call drm_atomic_helper_fake_vblank() from the generic commit_tail() helpers

2018-06-29 Thread Boris Brezillon
Now that we have a way to fake VBLANK events when requested by the CRTC hook it up to the generic commit_tail() helpers. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/drm_atomic_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c