Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > Add a parameter (in the form of a structure to ease future API > extensions) to the VSP atomic flush handler to pass CRC source > configuration, and pass the CRC value to the completion callback. > > Signed-off-by: Laurent Pinchart Only a

Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

2018-04-28 Thread Laurent Pinchart
Hi Jacopo, On Saturday, 28 April 2018 13:03:16 EEST jacopo mondi wrote: > Hi Laurent, >just one minor comment below > > On Mon, Apr 23, 2018 at 01:34:27AM +0300, Laurent Pinchart wrote: > > Add a parameter (in the form of a structure to ease future API > > extensions) to the VSP atomic flush

Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

2018-04-28 Thread jacopo mondi
Hi Laurent, just one minor comment below On Mon, Apr 23, 2018 at 01:34:27AM +0300, Laurent Pinchart wrote: > Add a parameter (in the form of a structure to ease future API > extensions) to the VSP atomic flush handler to pass CRC source > configuration, and pass the CRC value to the completion

[PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

2018-04-22 Thread Laurent Pinchart
Add a parameter (in the form of a structure to ease future API extensions) to the VSP atomic flush handler to pass CRC source configuration, and pass the CRC value to the completion callback. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 6 -- drivers/media/pl