Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-04-05 Thread Paul Cercueil
Le mercredi 05 avril 2023 à 16:50 +0200, Maxime Ripard a écrit : > On Wed, Apr 05, 2023 at 02:57:26PM +0200, Paul Cercueil wrote: > > Le lundi 27 mars 2023 à 21:24 +0200, Maxime Ripard a écrit : > > > On Fri, Mar 24, 2023 at 08:58:48PM +, Aidan MacDonald wrote: > > > > > > My suggestion: add a

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-04-05 Thread Maxime Ripard
On Wed, Apr 05, 2023 at 02:57:26PM +0200, Paul Cercueil wrote: > Le lundi 27 mars 2023 à 21:24 +0200, Maxime Ripard a écrit : > > On Fri, Mar 24, 2023 at 08:58:48PM +, Aidan MacDonald wrote: > > > > > My suggestion: add a per-clock bitmap to keep track of which > > > > > parents > > > > > are

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-04-05 Thread Paul Cercueil
Hi Maxime, Le lundi 27 mars 2023 à 21:24 +0200, Maxime Ripard a écrit : > On Fri, Mar 24, 2023 at 08:58:48PM +, Aidan MacDonald wrote: > > > > My suggestion: add a per-clock bitmap to keep track of which > > > > parents > > > > are allowed. Any operation that would select a parent clock not >

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-27 Thread Maxime Ripard
On Fri, Mar 24, 2023 at 08:58:48PM +, Aidan MacDonald wrote: > >> My suggestion: add a per-clock bitmap to keep track of which parents > >> are allowed. Any operation that would select a parent clock not on the > >> whitelist should fail. Automatic reparenting should only select from > >>

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-24 Thread Aidan MacDonald
Maxime Ripard writes: > On Thu, Mar 23, 2023 at 03:35:30PM +, Aidan MacDonald wrote: >> >> Stephen Boyd writes: >> >> > Quoting Maxime Ripard (2022-11-09 03:00:45) >> >> On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: >> >> > >> >> > Maxime Ripard writes: >> >> > >> >> >

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-24 Thread Maxime Ripard
Hi, On Thu, Mar 23, 2023 at 03:35:30PM +, Aidan MacDonald wrote: > > Stephen Boyd writes: > > > Quoting Maxime Ripard (2022-11-09 03:00:45) > >> On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: > >> > > >> > Maxime Ripard writes: > >> > > >> > > Hi, > >> > > > >> > > On

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-24 Thread Aidan MacDonald
Stephen Boyd writes: > Quoting Maxime Ripard (2022-11-09 03:00:45) >> On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: >> > >> > Maxime Ripard writes: >> > >> > > Hi, >> > > >> > > On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: >> > >> > Assigning the parent

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-22 Thread Stephen Boyd
Quoting Maxime Ripard (2022-11-09 03:00:45) > On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: > > > > Maxime Ripard writes: > > > > > Hi, > > > > > > On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: > > > > Assigning the parent clock in the DT works once, at

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-09 Thread Paul Cercueil
Hi Maxime, Le mer. 9 nov. 2022 à 11:53:01 +0100, Maxime Ripard a écrit : Hi Paul, On Sat, Nov 05, 2022 at 10:33:54AM +, Paul Cercueil wrote: Hi Maxime, Le ven. 4 nov. 2022 à 15:59:46 +0100, Maxime Ripard a écrit : > Hi Paul, > > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-09 Thread Maxime Ripard
On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: > > Maxime Ripard writes: > > > Hi, > > > > On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: > >> > >> Maxime Ripard writes: > >> > >> > Hi Paul, > >> > > >> > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-09 Thread Maxime Ripard
Hi Paul, On Sat, Nov 05, 2022 at 10:33:54AM +, Paul Cercueil wrote: > Hi Maxime, > > Le ven. 4 nov. 2022 à 15:59:46 +0100, Maxime Ripard a > écrit : > > Hi Paul, > > > > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: > > > Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-07 Thread Aidan MacDonald
Maxime Ripard writes: > Hi, > > On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: >> >> Maxime Ripard writes: >> >> > Hi Paul, >> > >> > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: >> >> Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a >> >> écrit : >>

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-07 Thread Maxime Ripard
Hi, On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: > > Maxime Ripard writes: > > > Hi Paul, > > > > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: > >> Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a > >> écrit : > >> > The Ingenic CGU clocks implements

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-05 Thread Aidan MacDonald
Maxime Ripard writes: > Hi Paul, > > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: >> Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a >> écrit : >> > The Ingenic CGU clocks implements a mux with a set_parent hook, but >> > doesn't provide a determine_rate

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-05 Thread Paul Cercueil
Hi Maxime, Le ven. 4 nov. 2022 à 15:59:46 +0100, Maxime Ripard a écrit : Hi Paul, On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a écrit : > The Ingenic CGU clocks implements a mux with a set_parent hook, but >

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-04 Thread Maxime Ripard
Hi Paul, On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: > Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a > écrit : > > The Ingenic CGU clocks implements a mux with a set_parent hook, but > > doesn't provide a determine_rate implementation. > > > > This is a bit odd, since

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-04 Thread Paul Cercueil
Hi Maxime, Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a écrit : The Ingenic CGU clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a

[PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-04 Thread Maxime Ripard
The Ingenic CGU clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely candidate to trigger that parent change is a call to