Re: [PATCH v2 8/8] drm/panfrost: Remove unnecessary flushing from tlb_inv_context

2019-08-23 Thread Steven Price
On 23/08/2019 03:12, Rob Herring wrote: tlb_inv_context() hook is only called when freeing the page tables. There's no point in flushing only to free the page tables immediately following. There is also a problem that we could be accessing the h/w when suspended. Cc: Tomeu Vizoso Cc: Steven Pri

Re: [PATCH v2 8/8] drm/panfrost: Remove unnecessary flushing from tlb_inv_context

2019-08-23 Thread Robin Murphy
On 23/08/2019 15:26, Rob Herring wrote: On Fri, Aug 23, 2019 at 9:05 AM Robin Murphy wrote: On 23/08/2019 14:18, Rob Herring wrote: On Fri, Aug 23, 2019 at 7:56 AM Robin Murphy wrote: On 23/08/2019 03:12, Rob Herring wrote: tlb_inv_context() hook is only called when freeing the page table

Re: [PATCH v2 8/8] drm/panfrost: Remove unnecessary flushing from tlb_inv_context

2019-08-23 Thread Rob Herring
On Fri, Aug 23, 2019 at 9:05 AM Robin Murphy wrote: > > On 23/08/2019 14:18, Rob Herring wrote: > > On Fri, Aug 23, 2019 at 7:56 AM Robin Murphy wrote: > >> > >> On 23/08/2019 03:12, Rob Herring wrote: > >>> tlb_inv_context() hook is only called when freeing the page tables. > >>> There's > >>>

Re: [PATCH v2 8/8] drm/panfrost: Remove unnecessary flushing from tlb_inv_context

2019-08-23 Thread Robin Murphy
On 23/08/2019 14:18, Rob Herring wrote: On Fri, Aug 23, 2019 at 7:56 AM Robin Murphy wrote: On 23/08/2019 03:12, Rob Herring wrote: tlb_inv_context() hook is only called when freeing the page tables. There's no point in flushing only to free the page tables immediately following. FWIW, in g

Re: [PATCH v2 8/8] drm/panfrost: Remove unnecessary flushing from tlb_inv_context

2019-08-23 Thread Rob Herring
On Fri, Aug 23, 2019 at 7:56 AM Robin Murphy wrote: > > On 23/08/2019 03:12, Rob Herring wrote: > > tlb_inv_context() hook is only called when freeing the page tables. There's > > no point in flushing only to free the page tables immediately following. > > FWIW, in general the point of flushing is

Re: [PATCH v2 8/8] drm/panfrost: Remove unnecessary flushing from tlb_inv_context

2019-08-23 Thread Robin Murphy
On 23/08/2019 03:12, Rob Herring wrote: tlb_inv_context() hook is only called when freeing the page tables. There's no point in flushing only to free the page tables immediately following. FWIW, in general the point of flushing is *because* we're about to free the pagetables - if there's any p

[PATCH v2 8/8] drm/panfrost: Remove unnecessary flushing from tlb_inv_context

2019-08-22 Thread Rob Herring
tlb_inv_context() hook is only called when freeing the page tables. There's no point in flushing only to free the page tables immediately following. There is also a problem that we could be accessing the h/w when suspended. Cc: Tomeu Vizoso Cc: Steven Price Cc: Alyssa Rosenzweig Cc: David Airli