[PATCH v2 linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-10 Thread Daniel Vetter
On Mon, Dec 10, 2012 at 09:29:17AM +0200, Jani Nikula wrote: > On Fri, 07 Dec 2012, Tim Gardner wrote: > > smatch warning: > > > > drivers/gpu/drm/i915/intel_display.c:7019 intel_set_mode() warn: function > > puts > > 500 bytes on stack > > > > Refactor so that saved_mode and saved_hwmode are dyn

[PATCH v2 linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-10 Thread Jani Nikula
On Fri, 07 Dec 2012, Tim Gardner wrote: > smatch warning: > > drivers/gpu/drm/i915/intel_display.c:7019 intel_set_mode() warn: function puts > 500 bytes on stack > > Refactor so that saved_mode and saved_hwmode are dynamically allocated as > opposed > to being automatic variables. 500 bytes seems

Re: [PATCH v2 linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-10 Thread Daniel Vetter
On Mon, Dec 10, 2012 at 09:29:17AM +0200, Jani Nikula wrote: > On Fri, 07 Dec 2012, Tim Gardner wrote: > > smatch warning: > > > > drivers/gpu/drm/i915/intel_display.c:7019 intel_set_mode() warn: function > > puts > > 500 bytes on stack > > > > Refactor so that saved_mode and saved_hwmode are dyn

Re: [PATCH v2 linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-09 Thread Jani Nikula
On Fri, 07 Dec 2012, Tim Gardner wrote: > smatch warning: > > drivers/gpu/drm/i915/intel_display.c:7019 intel_set_mode() warn: function puts > 500 bytes on stack > > Refactor so that saved_mode and saved_hwmode are dynamically allocated as > opposed > to being automatic variables. 500 bytes seems

[PATCH v2 linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-08 Thread Tim Gardner
smatch warning: drivers/gpu/drm/i915/intel_display.c:7019 intel_set_mode() warn: function puts 500 bytes on stack Refactor so that saved_mode and saved_hwmode are dynamically allocated as opposed to being automatic variables. 500 bytes seems like it could run the potential for blowing the kerne

[PATCH v2 linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers

2012-12-07 Thread Tim Gardner
smatch warning: drivers/gpu/drm/i915/intel_display.c:7019 intel_set_mode() warn: function puts 500 bytes on stack Refactor so that saved_mode and saved_hwmode are dynamically allocated as opposed to being automatic variables. 500 bytes seems like it could run the potential for blowing the kerne