Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-05-06 Thread Nirmoy Das
Hi Janusz, On 4/16/2024 6:40 PM, Rodrigo Vivi wrote: On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote: Hi Rodrigo, On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote: On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote: We defer actually closing,

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-29 Thread Thomas Hellström
On Thu, 2024-04-25 at 20:42 +0200, Janusz Krzysztofik wrote: > Hi Thomas, > > On Tuesday, 16 April 2024 18:40:12 CEST Rodrigo Vivi wrote: > > On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote: > > > Hi Rodrigo, > > > > > > On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-25 Thread Janusz Krzysztofik
Hi Thomas, On Tuesday, 16 April 2024 18:40:12 CEST Rodrigo Vivi wrote: > On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote: > > Hi Rodrigo, > > > > On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote: > > > On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-16 Thread Rodrigo Vivi
On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote: > Hi Rodrigo, > > On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote: > > On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote: > > > We defer actually closing, unbinding and destroying a VMA until next idle

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-16 Thread Janusz Krzysztofik
Hi Rodrigo, On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote: > On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote: > > We defer actually closing, unbinding and destroying a VMA until next idle > > point, or until the object is freed in the meantime. By postponing the >

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-15 Thread Rodrigo Vivi
On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote: > We defer actually closing, unbinding and destroying a VMA until next idle > point, or until the object is freed in the meantime. By postponing the > unbind, we allow for the VMA to be reopened by the client, avoiding the > work

[PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-15 Thread Janusz Krzysztofik
We defer actually closing, unbinding and destroying a VMA until next idle point, or until the object is freed in the meantime. By postponing the unbind, we allow for the VMA to be reopened by the client, avoiding the work required to rebind the VMA. It was assumed that as long as a GT is held