Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-05 Thread Linus Walleij
On Tue, Jul 4, 2023 at 5:13 PM Frank Binns wrote: > > > Signed-off-by: Sarah Walker > > > +properties: > > > + compatible: > > > +oneOf: > > > + - items: > > > + - enum: > > > + - ti,am62-gpu > > > + - const: img,powervr-seriesaxe > > > > I don't see why

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-04 Thread Frank Binns
Hi Linus, On Fri, 2023-06-16 at 14:48 +0200, Linus Walleij wrote: > Hi Sarah, > > thanks for your patch! > > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > Signed-off-by: Sarah

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-16 Thread Rob Herring
On Fri, Jun 16, 2023 at 6:49 AM Linus Walleij wrote: > > Hi Sarah, > > thanks for your patch! > > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > Signed-off-by: Sarah Walker > > >

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-16 Thread Linus Walleij
Hi Sarah, thanks for your patch! On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > > Signed-off-by: Sarah Walker > +properties: > + compatible: > +oneOf: > + - items: > + - enum:

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-16 Thread Frank Binns
Hi Andrew, Thank you for your feedback (comments below). On Tue, 2023-06-13 at 12:38 -0500, Andrew Davis wrote: > On 6/13/23 9:47 AM, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > Signed-off-by: Sarah Walker > > --- >

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-16 Thread Frank Binns
Hi Rob, On Thu, 2023-06-15 at 14:50 -0600, Rob Herring wrote: > On Tue, Jun 13, 2023 at 9:20 AM Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > Signed-off-by: Sarah Walker > > --- > >

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-15 Thread Rob Herring
On Tue, Jun 13, 2023 at 9:20 AM Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > > Signed-off-by: Sarah Walker > --- > .../devicetree/bindings/gpu/img,powervr.yaml | 71 +++ > MAINTAINERS

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-14 Thread Frank Binns
Hi Krzysztof, On Tue, 2023-06-13 at 20:24 +0200, Krzysztof Kozlowski wrote: > On 13/06/2023 16:47, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > I don't see improvements. That's a NAK :( > > This is a friendly

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-13 Thread Krzysztof Kozlowski
On 13/06/2023 16:47, Sarah Walker wrote: > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > I don't see improvements. That's a NAK :( This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-13 Thread Andrew Davis
On 6/13/23 9:47 AM, Sarah Walker wrote: Add the device tree binding documentation for the Series AXE GPU used in TI AM62 SoCs. Signed-off-by: Sarah Walker --- .../devicetree/bindings/gpu/img,powervr.yaml | 71 +++ MAINTAINERS | 7 ++ 2

[PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-13 Thread Sarah Walker
Add the device tree binding documentation for the Series AXE GPU used in TI AM62 SoCs. Signed-off-by: Sarah Walker --- .../devicetree/bindings/gpu/img,powervr.yaml | 71 +++ MAINTAINERS | 7 ++ 2 files changed, 78 insertions(+) create mode