Re: [PATCH v3 03/10] drm/bochs: Replace module-init boiler-plate code with DRM helpers

2021-12-22 Thread Javier Martinez Canillas
Hello Gerd, On 12/22/21 11:21, Gerd Hoffmann wrote: > On Wed, Dec 22, 2021 at 09:28:24AM +0100, Javier Martinez Canillas wrote: >> -static int __init bochs_init(void) >> -{ >> -if (drm_firmware_drivers_only() && bochs_modeset == -1) >> -return -EINVAL; > > Also cleanup bochs_modes

Re: [PATCH v3 03/10] drm/bochs: Replace module-init boiler-plate code with DRM helpers

2021-12-22 Thread Gerd Hoffmann
On Wed, Dec 22, 2021 at 09:28:24AM +0100, Javier Martinez Canillas wrote: > -static int __init bochs_init(void) > -{ > - if (drm_firmware_drivers_only() && bochs_modeset == -1) > - return -EINVAL; Also cleanup bochs_modeset? I guess its not used any more after this patch ... take

[PATCH v3 03/10] drm/bochs: Replace module-init boiler-plate code with DRM helpers

2021-12-22 Thread Javier Martinez Canillas
From: Thomas Zimmermann Remove custom bochs_init() and bochs_exit() functions and initialize the module with DRM module helpers. Signed-off-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/tiny/bochs.c | 20 ++-- 1 file