Re: [PATCH v3 1/2] drm/bridge: add Silicon Image SiI9234 driver

2017-09-11 Thread Krzysztof Kozlowski
On Mon, Sep 11, 2017 at 1:42 PM, Maciej Purski wrote: >>> + ctx->client[I2C_MHL] = client; >>> + >>> + ctx->client[I2C_TPI] = i2c_new_dummy(adapter, I2C_TPI_ADDR); >>> + if (!ctx->client[I2C_TPI]) { >>> + dev_err(ctx->dev, "failed to create TPI client\n"); >>> +

Re: [PATCH v3 1/2] drm/bridge: add Silicon Image SiI9234 driver

2017-09-11 Thread Krzysztof Kozlowski
On Mon, Sep 11, 2017 at 3:39 PM, Marek Szyprowski wrote: > Hi Krzysztof, > > > On 2017-09-11 15:18, Krzysztof Kozlowski wrote: >> >> On Mon, Sep 11, 2017 at 1:42 PM, Maciej Purski >> wrote: > > + ctx->client[I2C_MHL] = client; > + > + ctx->client[I2C_TPI] = i2c_new_dum

Re: [PATCH v3 1/2] drm/bridge: add Silicon Image SiI9234 driver

2017-09-11 Thread Marek Szyprowski
Hi Krzysztof, On 2017-09-11 15:18, Krzysztof Kozlowski wrote: On Mon, Sep 11, 2017 at 1:42 PM, Maciej Purski wrote: + ctx->client[I2C_MHL] = client; + + ctx->client[I2C_TPI] = i2c_new_dummy(adapter, I2C_TPI_ADDR); + if (!ctx->client[I2C_TPI]) { + dev_err(ctx->de

Re: [PATCH v3 1/2] drm/bridge: add Silicon Image SiI9234 driver

2017-09-11 Thread Maciej Purski
Hi Krzysztof, thank you for your comments. On 08.09.2017 at 19:05, Krzysztof Kozlowski wrote: On Tue, Sep 05, 2017 at 04:01:38PM +0200, Maciej Purski wrote: SiI9234 transmitter converts eTMDS/HDMI signal to MHL 1.0. It is controlled via I2C bus. Its interaction with other devices in video pipe

Re: [PATCH v3 1/2] drm/bridge: add Silicon Image SiI9234 driver

2017-09-09 Thread Krzysztof Kozlowski
On Tue, Sep 05, 2017 at 04:01:38PM +0200, Maciej Purski wrote: > SiI9234 transmitter converts eTMDS/HDMI signal to MHL 1.0. > It is controlled via I2C bus. Its interaction with other > devices in video pipeline is performed mainly on HW level. > The only interaction it does on device driver level i

[PATCH v3 1/2] drm/bridge: add Silicon Image SiI9234 driver

2017-09-05 Thread Maciej Purski
SiI9234 transmitter converts eTMDS/HDMI signal to MHL 1.0. It is controlled via I2C bus. Its interaction with other devices in video pipeline is performed mainly on HW level. The only interaction it does on device driver level is filtering-out unsupported video modes, it exposes drm_bridge interfac